chore: warnings

.github/workflows/ios.yml

@@ -9,13 +9,13 @@ on:
 jobs:
   build:
     name: Build and Test default scheme using any available iPhone simulator
-    runs-on: macos-14
+    runs-on: macos-15
 
     steps:
       - name: Checkout
         uses: actions/checkout@v3
       - name: Select Xcode Version
-        run: sudo xcode-select -switch /Applications/Xcode_15.4.app
+        run: sudo xcode-select -switch /Applications/Xcode_16.3.app
       - name: Set Default Scheme
         run: |
           scheme_list=$(xcodebuild -list -json | tr -d "\n")
@@ -25,6 +25,6 @@ jobs:
       - name: List Devices
         run: xcrun xctrace list devices 2>&1
       - name: Build
-        run: xcodebuild build-for-testing -scheme BDKSwiftExampleWallet -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 15,OS=17.5'
+        run: xcodebuild build-for-testing -scheme BDKSwiftExampleWallet -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4'
       - name: Run tests
-        run: xcodebuild test-without-building -scheme BDKSwiftExampleWallet -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 15,OS=17.5'
+        run: xcodebuild test-without-building -scheme BDKSwiftExampleWallet -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4'

.gitignore

@@ -90,4 +90,10 @@ fastlane/test_output
 iOSInjectionProject/
 
 # Other
-.DS_Store
+.DS_Store
+
+# Xcode Source Packages (SPM)
+SourcePackages/
+
+# VS Code specific
+.vscode/

BDKSwiftExampleWallet/Extensions/BDK+Extensions/Amount+Extensions.swift

@@ -8,7 +8,7 @@
 import BitcoinDevKit
 import Foundation
 
-extension Amount: Equatable {
+extension Amount: @retroactive Equatable {
     public static func == (lhs: Amount, rhs: Amount) -> Bool {
         return lhs.toSat() == rhs.toSat()
     }

BDKSwiftExampleWallet/Extensions/BDK+Extensions/Balance+Extensions.swift

@@ -8,7 +8,7 @@
 import BitcoinDevKit
 import Foundation
 
-extension Balance: Equatable {
+extension Balance: @retroactive Equatable {
     public static func == (lhs: Balance, rhs: Balance) -> Bool {
         return lhs.immature == rhs.immature && lhs.trustedPending == rhs.trustedPending
             && lhs.untrustedPending == rhs.untrustedPending && lhs.confirmed == rhs.confirmed

BDKSwiftExampleWallet/Extensions/BDK+Extensions/Connection+Extensions.swift

@@ -9,7 +9,7 @@ extension Connection {
         if FileManager.default.fileExists(atPath: walletDataDirectoryURL.path) {
             try FileManager.default.removeItem(at: walletDataDirectoryURL)
         }
-        
+
         try FileManager.default.ensureDirectoryExists(at: walletDataDirectoryURL)
         try FileManager.default.removeOldFlatFileIfNeeded(at: documentsDirectoryURL)
         let persistenceBackendPath = walletDataDirectoryURL.appendingPathComponent("wallet.sqlite")

BDKSwiftExampleWallet/Service/BDK Service/BDKService.swift

@@ -92,13 +92,13 @@ private class BDKService {
         let localOutputs = wallet.listUnspent()
         return localOutputs
     }
-    
+
     func createWallet(words: String?) throws {
         self.connection = try Connection.createConnection()
         guard let connection = connection else {
             throw WalletError.dbNotFound
         }
-        
+
         let savedURL = try? keyClient.getEsploraURL()
         let baseUrl = savedURL ?? network.url
 
@@ -138,7 +138,7 @@ private class BDKService {
         try keyClient.saveEsploraURL(baseUrl)
         self.esploraURL = baseUrl
         updateEsploraClient()
-        
+
         let wallet = try Wallet(
             descriptor: descriptor,
             changeDescriptor: changeDescriptor,
@@ -153,7 +153,7 @@ private class BDKService {
         guard let connection = connection else {
             throw WalletError.dbNotFound
         }
-        
+
         let savedURL = try? keyClient.getEsploraURL()
         let baseUrl = savedURL ?? network.url
 
@@ -208,7 +208,7 @@ private class BDKService {
         guard let connection = connection else {
             throw WalletError.dbNotFound
         }
-        
+
         let savedURL = try? keyClient.getEsploraURL()
 
         let baseUrl = savedURL ?? network.url
@@ -243,7 +243,7 @@ private class BDKService {
         try keyClient.saveEsploraURL(baseUrl)
         self.esploraURL = baseUrl
         updateEsploraClient()
-        
+
         let wallet = try Wallet(
             descriptor: descriptor,
             changeDescriptor: changeDescriptor,

BDKSwiftExampleWallet/Utilities/Constants.swift

@@ -5,9 +5,9 @@
 //  Created by Matthew Ramsden on 6/4/23.
 //
 
+import BitcoinDevKit
 import Foundation
 import SwiftUI
-import BitcoinDevKit
 
 struct Constants {
     struct Config {

BDKSwiftExampleWallet/View Model/Receive/ReceiveViewModel.swift

@@ -110,7 +110,7 @@ extension ReceiveViewModel {
     func readerSession(_ session: NFCNDEFReaderSession, didDetectNDEFs messages: [NFCNDEFMessage]) {
         if let message = messages.first,
             let record = message.records.first,
-            let payload = String(data: record.payload, encoding: .utf8)
+            let _ = String(data: record.payload, encoding: .utf8)
         {
             // Handle response
         }

BDKSwiftExampleWallet/View Model/Settings/SettingsViewModel.swift

@@ -9,6 +9,7 @@ import BitcoinDevKit
 import Foundation
 import SwiftUI
 
+@MainActor
 class SettingsViewModel: ObservableObject {
     let bdkClient: BDKClient