improv: simplify create wallet code #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1b2ns
force-pushed
the
improv/create-wallet-bdkservice
branch
from
8fa0f73 to
2db9a9e
Compare
|
Hey thanks for this! I will have a chance to review it next week |
|
Tks Reez |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the wallet creation code in BDKService to simplify connection initialization and URL retrieval, improving overall code readability. Key changes include:
- Moving connection creation logic into a dedicated extension in Connection+Extensions.swift.
- Replacing repetitive switch-case constructs for Esplora URL retrieval with a computed property on Network.
- Streamlining the createWallet methods across different wallet creation flows.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| BDKSwiftExampleWallet/Utilities/Constants.swift | Added an extension to Network for retrieving the Esplora URL based on network type. |
| BDKSwiftExampleWallet/Service/BDK Service/BDKService.swift | Simplified wallet creation by removing duplicate switch-case logic and utilizing the new connection creation helper. |
| BDKSwiftExampleWallet/Extensions/BDK+Extensions/Connection+Extensions.swift | Introduced a helper method for connection creation that encapsulates file management tasks. |
Files not reviewed (1)
- BDKSwiftExampleWallet.xcodeproj/project.pbxproj: Language not supported
|
great improvement, I like it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring connection creation in BitcoinKit for cleaner code in BDKService file.
Notes to the reviewers
Tiny PR to simplify the code readability.
Changelog notice
Checklists
All Submissions:
.swift-formatfileNew Features:
Bugfixes: