Skip to content

Including exception what() in Runaway dialog box #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Krellan
Copy link
Contributor

@Krellan Krellan commented May 26, 2025

If an exception happens, including e.what() in the text passed to the dialog box, so that the user can see it. This is in addition to any text from getWarnings() that might already be present, separated by newlines if so.

This will make it easier for users to find what went wrong and get the help they need, instead of having to tell the user to go back and dig through the debug.log file.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 26, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Copy link
Member

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an exception happens, including e.what() in the text passed to the dialog
box, so that the user can see it. This is in addition to any text from
getWarnings() that might already be present, separated by newlines if so.

Have you verified that we won't output the same error message twice?

@Krellan
Copy link
Contributor Author

Krellan commented May 27, 2025

As for the CI, it failed the Windows build because the URL https://github.com/boostorg/move/archive/boost-1.87.0.tar.gz: is no longer found. It's not related to this pull request.

If an exception happens, including e.what() in the text passed to the dialog
box, so that the user can see it.  This is in addition to any text from
getWarnings() that might already be present, separated by newlines if so.

This will make it easier for users to find what went wrong and get the help
they need, instead of having to tell the user to go back and dig through the
debug.log file.
@Krellan
Copy link
Contributor Author

Krellan commented May 27, 2025

Have you verified that we won't output the same error message twice?

I looked at the Warning class, and looked at its usages, and the messages that are passed in differ from the text that would arise if an exception were to be thrown (they come from different areas of the code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants