Skip to content

Commit e11b758

Browse files
committed
Merge bitcoin/bitcoin#28831: test: Avoid intermittent failures in feature_init
44445ae test: Avoid intermittent failures in feature_init (MarcoFalke) Pull request description: The code not only modifies block dat files, but also leveldb files, which may be of smaller size. Such corruption may not force leveldb to abort, according to the intermittent test failures. Fix the intermittent test failures by reverting bitcoin/bitcoin@5ab6419 . ACKs for top commit: kevkevinpal: lgtm ACK [44445ae](bitcoin/bitcoin@44445ae) fjahr: ACK 44445ae theStack: ACK 44445ae Tree-SHA512: 8084e4aeb8a976c1706a1898d7854c55d0c4ec7b5a08f65f97ffc173c935f9b0e0c1caef7be1538a458e4c018f7bd1948173349ec76ca48bc4013a63f284bb0f
2 parents 9c4b74f + 44445ae commit e11b758

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

test/functional/feature_init.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
#!/usr/bin/env python3
2-
# Copyright (c) 2021-2022 The Bitcoin Core developers
2+
# Copyright (c) 2021-present The Bitcoin Core developers
33
# Distributed under the MIT software license, see the accompanying
44
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
55
"""Stress tests related to node initialization."""
66
import os
77
from pathlib import Path
8-
from random import randint
98
import shutil
109

1110
from test_framework.test_framework import BitcoinTestFramework, SkipTest
@@ -138,8 +137,8 @@ def check_clean_start():
138137
# Since the genesis block is not checked by -checkblocks, the
139138
# perturbation window must be chosen such that a higher block
140139
# in blk*.dat is affected.
141-
tf.seek(randint (150, 15000))
142-
tf.write(b'1' * randint(20, 2000))
140+
tf.seek(150)
141+
tf.write(b"1" * 200)
143142

144143
start_expecting_error(err_fragment)
145144

0 commit comments

Comments
 (0)