Visual tweaks to the fee selector in the send form #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are purely cosmetic adjustments: - Make the font size of the selector the same as other send form fields - Lighter color for the option durations - Various spacing tweaks for a more harmonious appearance There are still some very minor details like item height, hover state, etc that we may tweak further as make our design system consistent. But these tweaks here get us very close.
johnny9
reviewed
Jun 5, 2025
| color: Theme.color.neutral3 | ||
| visible: delegate.hovered | ||
| } | ||
| Separator { |
There was a problem hiding this comment.
Is removing the Separator intentional? I mainly ask because it wasn't in your description of the changes.
There was a problem hiding this comment.
Yes. Separators are great for grouping/separating different types of options, but are not necessary for ones that go together. Like here in view menu of the MacOS calendar app.
johnny9
approved these changes
Jun 6, 2025
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
…the send form 1896c09 Visual tweaks to the fee selector in the send form (GBKS) Pull request description: These are purely cosmetic adjustments: - Make the font size of the selector copy the same as other send form fields - Lighter color for the option durations - Various spacing tweaks for a more harmonious appearance (for example, tighten up the overall popup padding, make the top and bottom padding of each item in the dropdown the same, visually balance left/right padding of each item...) There are still some very minor details like item height, hover state, etc that we may tweak further to make our design system consistent. But these tweaks here should get us very close.  How does that look? Anything else we should adjust? ACKs for top commit: johnny9: tACK 1896c09 Tree-SHA512: 6d29bc0385954b2a26e8e326081240e84ccc92019aead64649968d09ee26506e9ded6e38e4a3b8c9e508569c0fb57ac423a4ccdbe427f297fe7f2d7840eb4c08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are purely cosmetic adjustments:
There are still some very minor details like item height, hover state, etc that we may tweak further to make our design system consistent. But these tweaks here should get us very close.
How does that look? Anything else we should adjust?