Skip to content

Show "Select Wallet" or "Add Wallet" in the Wallet selector if a wallet isn't loaded #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

johnny9
Copy link
Collaborator

@johnny9 johnny9 commented Jun 5, 2025

In addition to changing the component in the top left corner, the navigation tabs will be hidden if no wallet is loaded until a wallet is created/selected.

Screenshot from 2025-06-05 00-05-47
Screenshot from 2025-06-05 00-08-48
Screenshot from 2025-06-05 00-06-08

@GBKS
Copy link
Contributor

GBKS commented Jun 5, 2025

Works great. One thing I noticed is that the Add wallet screen has a "Skip" button in the top-right. I think we discussed this previously, that the top buttons on the screen should be context specific. During onboarding, it should be a "Skip", and when entering that flow from within the main application, it should be a "Cancel".

The Context is used to change the nav bar text
@johnny9
Copy link
Collaborator Author

johnny9 commented Jun 6, 2025

Works great. One thing I noticed is that the Add wallet screen has a "Skip" button in the top-right. I think we discussed this previously, that the top buttons on the screen should be context specific. During onboarding, it should be a "Skip", and when entering that flow from within the main application, it should be a "Cancel".

Screenshot from 2025-06-05 23-20-53

@GBKS
Copy link
Contributor

GBKS commented Jun 6, 2025

ACK 03b568d

Thanks for adding that. I'd like to tweak some minor visual details on these, but I think this is good to merge and we can open a separate PR.

Was just looking through the code a bit and could not find the spot where it defines the transition direction for pages to appear from and disappear to. Based on context, we'll also need these to differ. Can you maybe point me to where that is defined?

@hebasto hebasto merged commit 0233931 into bitcoin-core:main Jun 6, 2025
9 checks passed
johnny9 pushed a commit to johnny9/bitcoin-core-app that referenced this pull request Jul 4, 2025
…in the Wallet selector if a wallet isn't loaded

1d9ed9c qml: Add Context to CreateWalletWizard (johnny9)
1c910c9 qml: Show Add Wallet in WalletBadge if none are found (johnny9)
f204d62 qml: Hide tabs and show Select Wallet if no wallet is loaded (johnny9)

Pull request description:

  In addition to changing the component in the top left corner, the navigation tabs will be hidden if no wallet is loaded until a wallet is created/selected.

  ![Screenshot from 2025-06-05 00-05-47](https://github.com/user-attachments/assets/6d7b7990-7472-45b7-ac65-9d334be2d9a5)
  ![Screenshot from 2025-06-05 00-08-48](https://github.com/user-attachments/assets/3c23e764-2650-4193-8067-6d04ed46c694)
  ![Screenshot from 2025-06-05 00-06-08](https://github.com/user-attachments/assets/526903d5-6fb6-4b44-b243-3109c8a69755)

ACKs for top commit:
  GBKS:
    ACK 1d9ed9c

Tree-SHA512: 33c6621af2b0d83a16b115369a10a094c395e4b252c3ab58f47384772654621a11084384bbdc0b245a28270ef46d09387c91d0c1b0f1d48ef0c78ad15941a381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants