Introduce standard fee selection to Send #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property will be used to set the target number of blocks for the standard fees listed in the UI drop down menu.
The FeeSelection component provides the standard fee options via a drop down menu.
goqusan
reviewed
Jun 1, 2025
goqusan
reviewed
Jun 1, 2025
|
Great to see. There are some visual tweaks to be made around spacing (separate PR probably), but otherwise looking good. |
MarnixCroes
reviewed
Jun 2, 2025
Good catch, I will try to fix this up.
The estimated fee will show up in the Review page so I felt that was good enough for now. |
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
439d8b0 qml: Cleanup QML in FeeSelection (johnny9) 1bdeb5a qml: Remove unnecessary Layout property in Send (johnny9) e47382a qml: Cleanup QML properties in FeeSelection (johnny9) 7ca2b8c qml: Introduce FeeSelection to Send (johnny9) d03898c qml: Add targetBlocks property to WalletQmlModel (johnny9) d7a41a0 qml: Add caret down icon (johnny9) Pull request description: This replaces the placeholder items in the Send form with a dropdown menu. The menu currently has 3 standard options (High, Default, and Low). These choices map to specific block targets for fee calculation.   ACKs for top commit: MarnixCroes: tACK 439d8b0 Tree-SHA512: a5b9f99091e8bb74c347e049a97923a306907e92afdaa09332512584685fdbebb26095574c686f69a750010fb983f0f34b1ff02235777f56e55fbe85736f009f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the placeholder items in the Send form with a dropdown menu. The menu currently has 3 standard options (High, Default, and Low). These choices map to specific block targets for fee calculation.