Skip to content

Add Skeleton loading to Activity #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Add Skeleton loading to Activity #460

merged 1 commit into from
Jun 5, 2025

Conversation

johnny9
Copy link
Collaborator

@johnny9 johnny9 commented May 31, 2025 •
edited
Loading

activity-skeleton.mp4

@GBKS
Copy link
Contributor

GBKS commented Jun 2, 2025

ACK. Looks great. I can't quite test it since I don't have a wallet that takes a long time to load, so I am just looking the video. There are some minor visual tweaks to do, but those can be done in a separate PR.

How can I test this properly? Do I need to create a wallet with 1K fake transactions? Or is there a fake delay I could insert in the code somewhere?

MarnixCroes
MarnixCroes approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK fa22e43

@johnny9
Copy link
Collaborator Author

johnny9 commented Jun 3, 2025

ACK. Looks great. I can't quite test it since I don't have a wallet that takes a long time to load, so I am just looking the video. There are some minor visual tweaks to do, but those can be done in a separate PR.

How can I test this properly? Do I need to create a wallet with 1K fake transactions? Or is there a fake delay I could insert in the code somewhere?

testnet and regtest wallets seem to work for me. With regtest, you can create a new wallet and use the generatetoaddress 101 myaddress to create a bunch of coinbase coins to yourself. For testnet, if you send me an address I try to send some utxos to you

@johnny9 johnny9 force-pushed the activity-skeleton branch from fa22e43 to b987ae5 Compare June 3, 2025 22:29
@johnny9
Copy link
Collaborator Author

johnny9 commented Jun 3, 2025

Update from fa22e43 to b987ae5

  • rebase with main

@GBKS GBKS mentioned this pull request Jun 4, 2025
Open
@GBKS
Copy link
Contributor

GBKS commented Jun 5, 2025

ACK. I just changed active: !walletController.initialized to active: true for checking out the skeleton.

As I mentioned in my previous comment, I think we can merge this and do some minor visual polish later.

@hebasto hebasto merged commit 7af5708 into bitcoin-core:main Jun 5, 2025
9 checks passed
johnny9 pushed a commit to johnny9/bitcoin-core-app that referenced this pull request Jul 4, 2025
@hebasto
Merge bitcoin-core/gui-qml#460: Add Skeleton loading to Activity
5613374 
508859c qml: Add Skeleton loading to Activity (johnny9)

Pull request description:

  https://github.com/user-attachments/assets/0b934c17-e1e3-4d60-b846-8b86949f8765

Top commit has no ACKs.

Tree-SHA512: 0b3033a0285fb8df3ced6672d9285e88140599791bad77e5247f99931e11b8d8462ca3a620452e086c0e35a8f627e2e0e79f9cb89d8e2c86954d3a6e1b682f2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarnixCroes MarnixCroes MarnixCroes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnny9 @GBKS @MarnixCroes @hebasto