Add Skeleton loading animation to the Wallet selector #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnny9
changed the title
gradientshimmer.mp4Here is an attempt at the gradient shimmer |
|
Looks great (from the video). Just built the code and tried to check it out in the app, but things load so quickly for me that I don't see it. Do I need to load it up with lots of transactions, or does it only show during IBD or so? Small thing I noticed is that the content of the wallet display wiggles a bit horizontally when the name is shorter/longer than the balance. Could we please align things to the left?
|
goqusan
reviewed
May 21, 2025
Created an issue to track this. It should be possible to fix the alignment. #456 |
hebasto
added a commit
that referenced
this pull request
May 23, 2025
1ba83b4 qml: Disable Send/Receive forms when loading (johnny9) 3a29670 qml: Add initialized property to WalletQmlController (johnny9) Pull request description: During loading, the Send and Receive forms are disabled and greyed out. This includes the initialized property added to WalletQmlController just as in #455   ACKs for top commit: MarnixCroes: tACK 1ba83b4 Tree-SHA512: 45b7324e77a529a1b7af7c663b701a346a292f2a8427088e3d0d51a5df856fadbf8b7b2c164eb0bbb7d0bf55dd48cc237d28d58fa58569b9fe8a5b507910b2dc
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
… Wallet selector 9a24e34 qml: Explicitly stop Skeleton Animation when not loading (johnny9) 933335e qml: Add fade-in animation to WalletBadge (johnny9) 264f0b1 qml: Add Skeleton loading animation to WalletBadge (johnny9) 0cfcffd qml: Introduce Skeleton.qml (johnny9) 0e0a957 qml: Fix walletqmlmodel.cpp include order (johnny9) d8b12db qml: Add initialized property to WalletQmlController (johnny9) Pull request description: This adds the first skeleton loading section to the desktop wallet. Specifically the WalletBadge at the top left corner that is used for selecting a wallet. https://github.com/user-attachments/assets/968c8da2-61af-459b-ad62-6b05c1ed7bb8 ACKs for top commit: hebasto: ACK 9a24e34, I have skimmed through the code and it looks OK. Tree-SHA512: df9dda2bdf3d11965d2cf575ff8db7c9ea0ea97308edc3bd4e4ee65c5ac70c89f491cd26f7393858dd33ce9e8ccf3d90095a56d053797101c1aeee589edcbcbf
johnny9
pushed a commit
to johnny9/gui-qml
that referenced
this pull request
Jul 10, 2025
2d0a81f qml: Disable Send/Receive forms when loading (johnny9) 5b56c2c qml: Add initialized property to WalletQmlController (johnny9) Pull request description: During loading, the Send and Receive forms are disabled and greyed out. This includes the initialized property added to WalletQmlController just as in bitcoin-core#455   ACKs for top commit: MarnixCroes: tACK 2d0a81f Tree-SHA512: 45b7324e77a529a1b7af7c663b701a346a292f2a8427088e3d0d51a5df856fadbf8b7b2c164eb0bbb7d0bf55dd48cc237d28d58fa58569b9fe8a5b507910b2dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first skeleton loading section to the desktop wallet. Specifically the WalletBadge at the top left corner that is used for selecting a wallet.
untitled.mp4