Add looping animation to Estimating state #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
added
UX
|
Looking good, I think it helps, although it feels just a tad too strong, especially when you also have the peer dots blinking. Could we try animating between Neutral 4 and Neutral 6, please? It also feels like this animates with a very slow frame rate, like it's lagging a bit (on a very fast MacBook). Do you see the same? |
jarolrod
force-pushed
the
estimating-animation
branch
from
a41be94 to
c95771e
Compare
jarolrod
force-pushed
the
estimating-animation
branch
from
c95771e to
1271377
Compare
D33r-Gee
reviewed
Jun 30, 2023
|
ACK 1271377 |
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
…tate 0cc2189 qml: add looping animation to Estimating state (Jarol Rodriguez) Pull request description: Implements the following design: BitcoinDesign/Bitcoin-Core-App#48 [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/325) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/325) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/325) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/325) ACKs for top commit: GBKS: ACK bitcoin-core/gui-qml@0cc2189 Tree-SHA512: 50ba69aa33a654db7bc4b0d6cf50c6a264c2daef43fc8a7a74c1a2a2ab27fa3de43920e44e5d692ea1ebcc785844d723f20eb7b573ff1cfb57743687e63e472d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the following design: BitcoinDesign/Bitcoin-Core-App#48