-
Notifications
You must be signed in to change notification settings - Fork 17
Fix registration code form button from disabling on invalid entry and… #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lmerchant
wants to merge
4
commits into
master
Choose a base branch
from
lmm_ffq_button_issue_309
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bbf8574
Fix registration code form button from disabling on invalid entry and…
lmerchant 02cd657
Remove extra handle submit function and move disable button into plug…
lmerchant 30b42b5
Add form submit to jQuery validation plugin on FFQ registration code
lmerchant 31a3904
Fix FFQ code registration submit button when clicked
lmerchant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,43 +44,39 @@ | |
preventImplicitSubmission(form_name); | ||
preclude_whitespace('#ffq_code'); | ||
|
||
$("form[name='" + form_name + "']").on('submit', function() { | ||
document.getElementById("ffq_code_button").disabled = true; | ||
}); | ||
function handleSubmit() { | ||
// TODO go to page since form validated | ||
console.log('submitted form') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please make sure to remove debug info before opening pull requests. |
||
}; | ||
|
||
// Initialize form validation on the registration form. | ||
// It has the name attribute "registration" | ||
// Validate the registration form for a valid | ||
// registration code using the jQuery validation plugin. | ||
// If the form is not valid, the messages are displayed | ||
$("form[name='" + form_name + "']").validate({ | ||
// Specify validation rules | ||
rules: { | ||
// The key name on the left side is the name attribute | ||
// of an input field. Validation rules are defined | ||
// on the right side | ||
// The key is the form input field name attribute and the validation rules | ||
// are defined in the value object | ||
// The route check_ffq_code_valid returns | ||
// either true or false | ||
ffq_code: { | ||
required: true, | ||
remote: { | ||
url: "/check_ffq_code_valid", | ||
} | ||
}, | ||
submitHandler: function (form) { | ||
form.submit(); | ||
} | ||
}, | ||
submitHandler: function (form, event) { | ||
// prevent multiple submissions | ||
document.getElementById("ffq_code_button").disabled = false; | ||
handleSubmit(form); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is a helper function necessary here? |
||
}, | ||
messages: { | ||
ffq_code: "{{ _('Your registration code is not in our system or has already been used. Please try again.') }}", | ||
}, | ||
}); | ||
}); | ||
|
||
/* | ||
function updateButtonState(ffq_code_value) { | ||
if(ffq_code_value != "") { | ||
document.getElementById("ffq_code_button").disabled = false; | ||
} else { | ||
document.getElementById("ffq_code_button").disabled = true; | ||
} | ||
} | ||
*/ | ||
}); | ||
|
||
function openCodePanel() { | ||
document.getElementById('add_code_container').style.display = ''; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be addressed before we can consider merging the pull request. As it stands, this PR breaks the functionality for the tool.