Skip to content

Fix: Disable cache control and x formatted by header #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 1, 2025
Merged

Fix: Disable cache control and x formatted by header #52

merged 5 commits into from
Jul 1, 2025

Conversation

arpitmalik
Copy link
Contributor

No description provided.

@arpitmalik arpitmalik mentioned this pull request May 3, 2024
Closed
wojciechkrol
wojciechkrol reviewed May 3, 2024
View reviewed changes
@arpitmalik
Copy link
Contributor Author

@wojciechkrol @EmilJunker Thank you for the patience. Please review now.

@arpitmalik
Copy link
Contributor Author

@wojciechkrol @EmilJunker Any update?

@EmilJunker
Copy link
Contributor

@arpitmalik Your changes look good to me, although it's a bit difficult to review because of all the unrelated formatting changes you made. I must say that I'm not a big fan of stretching simple if conditions and function calls over multiple lines of code.

@arpitmalik
Copy link
Contributor Author

Please merge the code if it looks good. Formatting is done only to make the code readable.

@greenlihui
Copy link

Please merge the code if it looks good. Formatting is done only to make the code readable.

I guess formatting was automatically made by code editor plugins like prettier?
I suggest leave these unrelated formatting untouched and obey the one-line condition rule on newly added lines as the author said, everyone have a different opinion on readable code, and you may not want him spend extra time on restoring code to how it looked before.

@arpitmalik
Copy link
Contributor Author

arpitmalik commented Oct 3, 2024 •
edited
Loading

@EmilJunker @wojciechkrol Please merge now.

@EmilJunker
Copy link
Contributor

LGTM 👍

@wojciechkrol Can you please merge this as well as #63. Both of these pull requests would make great additions to this library.

@arpitmalik
Copy link
Contributor Author

@wojciechkrol Can we please merge this on priority? Please check.

@DeepikaSharma5
Copy link

DeepikaSharma5 commented Nov 12, 2024 •
edited
Loading

@wojciechkrol Can you please merge both these on priority. Its been more than 3 months.

@arpitmalik
Copy link
Contributor Author

@wojciechkrol Reminder^

@arpitmalik
Copy link
Contributor Author

@wojciechkrol Please merge

@arpitmalik
Copy link
Contributor Author

@wojciechkrol Please be active on this. Merge this pull request as soon as possible.

@wojciechkrol wojciechkrol self-assigned this Dec 18, 2024
@arpitmalik
Copy link
Contributor Author

@wojciechkrol Please merge

1 similar comment
@arpitmalik
Copy link
Contributor Author

@wojciechkrol Please merge

@wojciechkrol wojciechkrol merged commit f4507e6 into binaryminds:master Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciechkrol wojciechkrol wojciechkrol left review comments

@EmilJunker EmilJunker EmilJunker left review comments

@greenlihui greenlihui greenlihui left review comments

Assignees

@wojciechkrol wojciechkrol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arpitmalik @EmilJunker @greenlihui @DeepikaSharma5 @wojciechkrol