-
Notifications
You must be signed in to change notification settings - Fork 0
fix: add readii cli entry point to pyproject #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (4)pyproject.toml (4)
The classifiers are properly formatted and accurately reflect the project's metadata, including supported Python versions that match the requires-python field. Line range hint The comment indicates that dicom-parser is being removed due to updated med-imagetools. Please verify that all functionality previously provided by dicom-parser is now covered by med-imagetools. #!/bin/bash
# Search for any remaining dicom-parser imports or usage
rg "from dicom_parser import|import dicom_parser"
# Check if med-imagetools provides similar functionality
rg "from med_imagetools.*import.*dicom"
Please ensure that the #!/bin/bash
# Check if the main function exists and is properly implemented
ast-grep --pattern 'def main($$$)'
# Look for typical CLI patterns (argparse, click, etc.)
rg -A 10 "def main" src/readii/pipeline.py
Breaking Change: Minimum Python version increased to 3.10 This change increases the minimum required Python version from 3.9 to 3.10, which is a breaking change that could affect users. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 62.80% 62.80%
=======================================
Files 9 9
Lines 535 535
=======================================
Hits 336 336
Misses 199 199 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
New Features
readii
.Changes