-
Notifications
You must be signed in to change notification settings - Fork 0
build: upgrade numpy #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade numpy #120
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe changes update the dependency specification for NumPy in the project configuration, broadening the allowed version range. Additionally, in a test file, the reference to NumPy's NaN value is standardized from Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pixi.lock
is excluded by!**/*.lock
📒 Files selected for processing (2)
pyproject.toml
(1 hunks)tests/test_negative_controls.py
(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI-CD
pyproject.toml
[error] 1-1: pixi install failed: lock-file not up-to-date with the project. The process exited with code 1.
🔇 Additional comments (1)
tests/test_negative_controls.py (1)
270-270
: Standardize NaN usage – approved.Replacing
np.NaN
with the lowercasenp.nan
is correct and aligns with NumPy best practices for versions ≥2.x.
"pyradiomics-bhklab>=3.1.4,<4", | ||
"orcestra-downloader>=0.9.0,<1", | ||
"numpy==1.26.4.*", | ||
"numpy>=2.2.5,<3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update lock-file after dependency change.
The numpy
requirement has been broadened to >=2.2.5,<3
, but CI is failing with a stale lock-file. Please regenerate/update the lock-file (e.g., via pixi lock
or the equivalent) so that it reflects this new version range.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 76.45% 76.45%
=======================================
Files 41 41
Lines 2009 2009
=======================================
Hits 1536 1536
Misses 473 473 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit