Skip to content

Conversation

strixy16
Copy link
Collaborator

@strixy16 strixy16 commented Apr 28, 2025

Summary by CodeRabbit

  • Chores
    • Updated the supported version range for the numpy dependency to allow newer versions.
    • Standardized the reference to NaN values in tests to use lowercase np.nan for consistency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 28, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pixi.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update the dependency specification for NumPy in the project configuration, broadening the allowed version range. Additionally, in a test file, the reference to NumPy's NaN value is standardized from np.NaN to np.nan in both active and commented lines. No public interfaces or exported entities are altered.

Changes

File(s) Change Summary
pyproject.toml Updated NumPy dependency from exact version 1.26.4.* to version range >=2.2.5,<3; added a trailing space to the pandas dependency line.
tests/test_negative_controls.py Replaced np.NaN with np.nan in test code, standardizing the reference to NumPy's NaN value.

Poem

In the garden of code, dependencies grew,
NumPy now stretches, with versions anew.
Pandas kept tidy, with a space at the end,
While nan got a facelift, its case to amend.
Rabbits rejoice, for clarity’s won—
Onward we hop, with our code finely spun! 🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 389a003 and 84274cd.

⛔ Files ignored due to path filters (1)
  • pixi.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • pyproject.toml (1 hunks)
  • tests/test_negative_controls.py (2 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI-CD
pyproject.toml

[error] 1-1: pixi install failed: lock-file not up-to-date with the project. The process exited with code 1.

🔇 Additional comments (1)
tests/test_negative_controls.py (1)

270-270: Standardize NaN usage – approved.

Replacing np.NaN with the lowercase np.nan is correct and aligns with NumPy best practices for versions ≥2.x.

"pyradiomics-bhklab>=3.1.4,<4",
"orcestra-downloader>=0.9.0,<1",
"numpy==1.26.4.*",
"numpy>=2.2.5,<3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update lock-file after dependency change.

The numpy requirement has been broadened to >=2.2.5,<3, but CI is failing with a stale lock-file. Please regenerate/update the lock-file (e.g., via pixi lock or the equivalent) so that it reflects this new version range.

@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.45%. Comparing base (389a003) to head (8d35a94).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   76.45%   76.45%           
=======================================
  Files          41       41           
  Lines        2009     2009           
=======================================
  Hits         1536     1536           
  Misses        473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@strixy16 strixy16 merged commit 08db913 into main Apr 28, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in READII-2-ROQC Pipeline Apr 28, 2025
@strixy16 strixy16 deleted the katys/update-numpy branch April 28, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant