Add support for JSON Schema $defs, definitions, $ref, oneOf, anyOf and others in PropertyDefinition #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opertyDefinition This PR extends PropertyDefinition to support additional JSON Schema draft-07 elements: $defs (for schema definitions) definitions $ref (schema references) anyOf (combining subschemas) These additions improve compatibility with more complex JSON Schema structures.
|
@dotnet-policy-service agree |
repko-artem
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR extends PropertyDefinition to support additional JSON Schema keywords from both draft-07 and 2020-12 specifications for richer schema definitions and validation.
- Removed the hardcoded
"object"default onTypeand made it nullable - Added support for
const,title,minimum,maximum, and legacydefinitions/$defs - Introduced
$ref,anyOf, andoneOfproperties for schema composition
Comments suppressed due to low confidence (2)
OpenAI.SDK/ObjectModels/SharedModels/FunctionParameters.cs:26
- Removing the default "object" value may break existing consumers that rely on a default type; consider providing a fallback or retaining the default assignment.
public string? Type { get; set; }
OpenAI.SDK/ObjectModels/SharedModels/FunctionParameters.cs:135
- Consider adding unit tests to verify serialization and validation behavior for the newly added
anyOf,oneOf, and other schema composition properties.
public IList<PropertyDefinition>? AnyOf { get; set; }
…f, exclusiveMinimum, exclusiveMaximum, format, pattern, minItems, maxItems
…ultipleOf - can be float" This reverts commit 477569b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends PropertyDefinition to support additional JSON Schema draft-07 elements:
These additions improve compatibility with more complex JSON Schema structures.