configure.ac: upgrade ancient snprintf macro to modern autoconf-archive edition #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding calls to builtin(include) of all things! autoreconf will detect existing macros in the specified macros directory automatically and ensure that calls to `m4_include()` are synthesized for you. We use ACLOCAL_AMFLAGS to ensure that updated versions of macros we use get locally installed.
…ve edition ac_func_snprintf was very old, and produced illogical results with modern compilers. Specifically, the check always failed and claimed: ``` checking for snprintf... yes checking for vsnprintf... yes checking for working snprintf... no checking for working vsnprintf... no configure: WARNING: Will use fallback (v)snprintf() implementation. ``` autoconf-archive has migrated to a dedicated AX_ namespace and released a couple decades worth of improvements, including fixing this particular bug in 2022. Bug: https://bugs.gentoo.org/898602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ac_func_snprintf was very old, and produced illogical results with modern compilers. Specifically, the check always failed and claimed:
autoconf-archive has migrated to a dedicated AX_ namespace and released a couple decades worth of improvements, including fixing this particular bug in 2022.
Bug: https://bugs.gentoo.org/898602