Skip to content

Conversation

3togo
Copy link

@3togo 3togo commented Feb 11, 2019

Some minor modifications to make it compatible to windows 10

Eli

Copy link
Owner

@benjmarshall benjmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, this looks good. I'd like to test this PR locally on my Linux box before merging to make sure no existing functionality is broken. I'll try and get to this ASAP.

@benjmarshall
Copy link
Owner

Hi Eli,

The latest updates here look good. I have pulled the latest revision and tested on my linux box to make sure there are no breaking changes, looks all good.

Do you think there is much more to do to close out the functionality you wanted to add?

One request i do have - in your latest commit - 8a5b9ab - you included the generated files for one of the examples. Could you roll this commit back to clean up these files?

I also think it would be good to have an example project with the new cflags options, have you got something simple you are using for testing which could be added?

Cheers,
Ben

@3togo
Copy link
Author

3togo commented Apr 17, 2019 via email

@3togo
Copy link
Author

3togo commented Apr 17, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants