breaking: Change Tailscale onboarding behavior #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a series of breaking changes.
Previous behavior in Tailscale was to add
-1to the end of a hostname if that hostname was already registered to a different machine.Now the userdata.sh script will make a few API calls to clear the hostname that matches the AWS Lightsail instance that is in the process of onboarding. This requires the use of an OAuth client to make the API calls and complete registration. A tailnet key is no longer required.
Since a tailnet key is no longer required, the
tailscaleprovider is no longer required. Additionally thetimeprovider is no longer used directly by this module so it has also been removed.Some flexibility has been added to how instance and hostname names are set. Previously they were a pattern built from different variables, but now they are both single variables that can be independently customized from the calling/root module instead of inside this module.
The
lightsail_bundle_idhas been parameterized, allowing larger instances to be deployed. Use caution, as IPv6-only bundles might not work withip_address_type = dualstack.Finally terraform-docs examples have been brought up to date.