GSoC warm up task #236

lorforlinux · 2020-06-06T13:26:15Z

@jadonk GSoC2020 warm-up task.

http://git.ti.com/gitweb/?p=processor-firmware/ti-amx3-cm3-pm-firmware.git;a=commit;h=6a849767df85ce9399494f53fb5c753665396653 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

https://github.com/beagleboard/BeagleBoard-DeviceTrees/tree/v4.14.x-ti beagleboard/BeagleBoard-DeviceTrees@d7cdfa9 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Reference: v5.3.18 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Reference: v5.0.21 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Reference: v4.14.77 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this so-called CLM blob file. It uses the same naming scheme as the other firmware files with extension of .clm_blob. The CLM blob file is optional. If the file does not exist, the download process will be bypassed. It will not affect the driver loading. Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> Signed-off-by: Chung-Hsien Hsu <stanley.hsu@cypress.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

We got SDIO_CRC_ERROR with 4373 on SDR104 when doing bi-directional throughput test. Setting F2 blocksize and enable watermark to 256 to guarantee the operation stability. Signed-off-by: Wright Feng <wright.feng@cypress.com>

broken_sg_support, sd_head_align, and sd_sgentry_align are used in brcmfmac code but not configurable in dts file. Add the parsing logic. Now they can be configured like below in dts: brcm,broken_sg_support; brcm,sd_head_align = /bits/ 16 <4>; brcm,sd_sgentry_align = /bits/ 16 <4>; Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>

Firmware returns proprietary error code when getting error in fil_cmd_data_set or fil_cmd_data_get. Sometimes the vendor tool or utilities which uses libnl may stuck in some commands when wl is down. For example, issue "scan" command after issuing "down" command, the "scan" command will be the blocking call and stuck as no response from firmware. It is caused by that firmware returns BCME_NOTUP(-4) when wl is down, but in Linux the -4 is -EINTR, so libnl catches the error and not pass to upper layer. Because of that, the driver should return Linux error code instead of the proprietary error code, and the tools or utilities need to get the real firmware error code by another command "bcmerrorstr" after receiving the error. Signed-off-by: Wright Feng <wright.feng@cypress.com>

CYW43012 is a 1x1 802.11a/b/g/n Dual-Band HT20, 256-QAM/Turbo QAM. It is an Ultra Low Power WLAN+BT combo chip. Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>

APSTA can work on two band concurrently with using VSDB(Virtual Simultaneous Dual-Band) or RSDB(Real Simultaneous Dual-Band) features. In this case, we have to keep apsta is 1 in firmware side. If we start wpa_supplicant on wlan0 and then start hostapd on wlan1, the apsta will be set to 0, and data will be stall on wlan0(station). Because that, we only set apsta to 0 when AP start on primary interface. Signed-off-by: Wright Feng <wright.feng@cypress.com>

Saverestore register settings for 43012. Signed-off-by: Praveen Babu Chandran <pucn@cypress.com>

This patch will add 43455 into the save-restore(SR) capable chip list, so the SR engine will be enabled with 43455 FW which built-in the -sr function. Signed-off-by: Lo-Hsiang Lo <double.lo@cypress.com>

…bled For legacy chips w/o CLM blob files, kernel with user helper function enabled returns -EAGAIN when we request_firmware() for blob file: "request_firmware() -> _request_firmware() -> fw_load_from_user_helper() -> _request_firmware_load() -> retval=-EAGAIN" We should do retries and also continue brcmf_c_process_clm_blob if getting -EAGAIN from request_firmware function. Signed-off-by: Wright Feng <wright.feng@cypress.com>

The buffer size of return of cap iovar is greater than 256 bytes in some firmares. For instance, the return size of cap iovar is 271 bytes in 4373 13.10.246.79 firmare. It makes caps buffer is default value and cause the feature capability parsing failed. Because of that, we enlarge caps buffer size to 512 bytes and add the error print for cap iovar error. Signed-off-by: Wright Feng <wright.feng@cypress.com>

Linux 3.6 introduces TSQ which has a per socket threshold for TCP Tx packet to reduce latency. In fcmode 1/2, host driver enqueues skb in hanger and TCP doesn't push new skb frees until host frees the skb when receiving fwstatus event. So using skb_orphan before sending skb to bus will make the skb removing the ownership of socket. With this patch, we got better throughput in fcmode 1/2. Tested 43455 TCP throughput in 20 MHz bandwidth with/without this patch. fcmode 0: 59.5 / 59.6 (Mbps) fcmode 1: 59.3 / 23.4 (Mbps) fcmode 2: 59.6 / 21.5 (Mbps) Signed-off-by: Wright Feng <wright.feng@cypress.com>

…DP RX Traffic. The number of words that the read FIFO has to contain except the end of frame before sends data back to the host. Max watermark = (512B - 2* (BurstLength))/4 = (512 - 128)/4 = 384/4 = 0x60 so if burst length (i.e. BurstLength = 64) is increased, watermark has to be reduced. This is the optimal setting for this chip. Signed-off-by: Naveen Gupta <nagu@cypress.com>

In Deep Sleep mode ARM is off and once Exit trigger comes than Mail Box Interrupt comes to Host and whole Re Initiation should be done in the ARM to start TX/RX. Signed-off-by: Naveen Gupta <nagu@cypress.com>

Add WLAN_AKM_SUITE_FT_8021X and WLAN_AKM_SUITE_FT_PSK in brcmf_set_key_mgmt() for FT support. Signed-off-by: Chung-Hsien Hsu <stanley.hsu@cypress.com> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>

Hostap daemon has a parameter "ap_isolate which is used to prevent low-level bridging of frames between associated stations in the BSS. For driver side, we add cfg80211 ops method change_bss to support setting AP isolation from user space. Signed-off-by: Wright Feng <wright.feng@cypress.com> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>

Don't print ulp_sdioctrl get error as errors are expected for non ulp cases. Signed-off-by: Naveen Gupta <nagu@cypress.com>

There is a system warning message, warn_slowpath-fmt, during suspend while using supplicant join AP and enable wowl feature by IW command. It's cuased by brcmf_pno_remove_request path can't find the reqid. This fix will not go to remove pno request function if there is no pno scan. Signed-off-by: Lo-Hsiang Lo <double.lo@cypress.com>

To enhance RX throughput, we add a module parameter "sdio_dpc_prio" to let user can set scheduling priority for sdio_dpc. It can improve RX throughput by reducing the receiving time in sdio_dpc. Signed-off-by: Wright Feng <wright.feng@cypress.com>

When eap_restrict is enabled, firmware will toss non-802.1x frames from tx/rx data path if station not yet authorized. Internal firmware eap_restrict is disabled by default. This patch makes it possible to enable firmware eap_restrict by specifying eap_restrict=1 as module parameter. Signed-off-by: Wright Feng <wright.feng@cypress.com>

FMAC driver need to provide a dummy wowlan filter for kernel and provided the well configured wowlan stack. So the system will keep driver in connected state in suspend mode and can be wake up by ping packet. Enable unicast packet filter before system suspend and disable it after resume. Signed-off-by: Lo-Hsiang Lo <double.lo@cypress.com>

Set wowl configuration in disconnect state is redundant. Remove it to fix no scan result issue after resume. Signed-off-by: Lo-Hsiang Lo <double.lo@cypress.com>

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Signed-off-by: Jason Kridner <jdk@ti.com>

Hacked driver that has audio support. Use this temporarily until audio support can be added to the upstream adv7511 driver. Signed-off-by: Jason Kridner <jdk@ti.com> [Remove slave hacks and use adv75xx compatible strings] Signed-off-by: Matt Porter <mporter@konsulko.com>

Convert the driver over the the device model component framework, making use of the drm encoder/connector helpers. This allows adihdmi to be dynamically selected as an external encoder for drm drivers like tilcdc that support the DT graph binding which defines ports and remote-endpoints to attach external encoders. Also, this driver was modified by another developer to support audio and tweak some settings. Along the way it seems to have been reformatted to 4 space tabs which is hard to work with alongside the standard 8 space tabs in the kernel coding standard. As such, this is reformatted to standard 8 space tabs so it's a bit more readable. The component and audio support should be merged into the upstream driver so this adihdmi driver can be removed. Signed-off-by: Matt Porter <mporter@konsulko.com>

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

This crashes the kernel when an runtime overlay is applied.

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

We have errata i688 workaround produce warnings on SoCs other than omap4 and omap5: omap4_sram_init:Unable to allocate sram needed to handle errata I688 omap4_sram_init:Unable to get sram pool needed to handle errata I688 This is happening because there is no ti,omap4-mpu node, or no SRAM to configure for the other SoCs, so let's remove the warning based on the SoC revision checks. As nobody has complained it seems that the other SoC variants do not need this workaround. Signed-off-by: Tony Lindgren <tony@atomide.com>

already default on BBB/X15, just calcuated everybootup Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Reference: v5.2.21 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

4.14.108-ti-r135 bb.org_defconfig AUFS: sfjro/aufs4-standalone@df5c09a BBDTBS: beagleboard/BeagleBoard-DeviceTrees@d7cdfa9 CAN-ISOTP: hartkopp/can-isotp@ced84ca TI_AMX3_CM3: http://git.ti.com/gitweb/?p=processor-firmware/ti-amx3-cm3-pm-firmware.git;a=commit;h=6a849767df85ce9399494f53fb5c753665396653 WIREGUARD: https://git.zx2c4.com/WireGuard/commit/edad0d6e99e5133b1e8e865d727a25fff6399cb4 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

dlech

Hi. I just wanted to say good luck with your GSoC project and share a few things I have learned myself from contributing tot he Linux kernel.

dlech · 2020-06-06T16:40:11Z

drivers/char/gsochar.c

+ *  @param inodep A pointer to an inode object (defined in linux/fs.h)
+ *  @param filep A pointer to a file object (defined in linux/fs.h)
+ */
+static int dev_open(struct inode *inodep, struct file *filep){


In the Linux kernel even private/static functions and global variables still usually have a namespace prefix, e.g. gsochar_dev_open().

thanks, will change this :)

dlech · 2020-06-06T16:42:50Z

drivers/char/gsochar.c

+ */
+static int dev_open(struct inode *inodep, struct file *filep){
+   numberOpens++;
+   printk(KERN_INFO "gsochar: Device has been opened %d time(s)\n", numberOpens);


pr_info() is a shortcut for this.

I am very new to kernel programming and I thought instead of using pr_info() it would be a good idea to use the longer version just to learn about different kernel log message levels.

dlech · 2020-06-06T16:48:04Z

drivers/char/gsochar.c

+ * @version 0.1
+ * @brief   Warmp up task for GSoC2020.
+ * @see 	https://github.com/lorforlinux/gsoc-simple-char
+ */


This is a very nice header and documentation.

But... if you were submitting it to the mainline kernel, it would not be accepted. You can read more about kernel coding style at https://www.kernel.org/doc/html/latest/process/coding-style.html.

Very helpful piece of information, thank you so much :)
I will leave this one as it is and follow the Linux kernel coding style for future pull requests, Is that okay?

dlech · 2020-06-06T17:01:11Z

drivers/char/gsochar.c

+static ssize_t dev_read(struct file *filep, char *buffer, size_t len, loff_t *offset){
+
+	int bytesRead;
+	int bytesToRead = BUFFER_SIZE - *offset;


Shouldn't bytesToRead also depend on len?

dlech · 2020-06-06T17:01:48Z

drivers/char/gsochar.c

+	int bytesToRead = BUFFER_SIZE - *offset;
+
+	// If we are at the end of the file, STOP READING!
+	if (bytesToRead == 0){


Should this be <= 0?

[ Upstream commit f95d186255b319c48a365d47b69bd997fecb674e ] [BUG] When trying read-only scrub on a btrfs with rescue=idatacsums mount option, it will crash with the following call trace: BUG: kernel NULL pointer dereference, address: 0000000000000208 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page CPU: 1 UID: 0 PID: 835 Comm: btrfs Tainted: G O 6.15.0-rc3-custom+ #236 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS unknown 02/02/2022 RIP: 0010:btrfs_lookup_csums_bitmap+0x49/0x480 [btrfs] Call Trace: <TASK> scrub_find_fill_first_stripe+0x35b/0x3d0 [btrfs] scrub_simple_mirror+0x175/0x290 [btrfs] scrub_stripe+0x5f7/0x6f0 [btrfs] scrub_chunk+0x9a/0x150 [btrfs] scrub_enumerate_chunks+0x333/0x660 [btrfs] btrfs_scrub_dev+0x23e/0x600 [btrfs] btrfs_ioctl+0x1dcf/0x2f80 [btrfs] __x64_sys_ioctl+0x97/0xc0 do_syscall_64+0x4f/0x120 entry_SYSCALL_64_after_hwframe+0x76/0x7e [CAUSE] Mount option "rescue=idatacsums" will completely skip loading the csum tree, so that any data read will not find any data csum thus we will ignore data checksum verification. Normally call sites utilizing csum tree will check the fs state flag NO_DATA_CSUMS bit, but unfortunately scrub does not check that bit at all. This results in scrub to call btrfs_search_slot() on a NULL pointer and triggered above crash. [FIX] Check both extent and csum tree root before doing any tree search. Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>

RobertCNelson and others added 30 commits May 15, 2020 13:20

Add AM335x CM3 Power Managment Firmware

c8b89ac

http://git.ti.com/gitweb/?p=processor-firmware/ti-amx3-cm3-pm-firmware.git;a=commit;h=6a849767df85ce9399494f53fb5c753665396653 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Add BeagleBoard.org DTBS: v4.14.x-ti

f22ff03

https://github.com/beagleboard/BeagleBoard-DeviceTrees/tree/v4.14.x-ti beagleboard/BeagleBoard-DeviceTrees@d7cdfa9 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

backports: stmpe: from: linux.git

8db7cc0

Reference: v5.3.18 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

stmpe: wire up adc Kconfig/Makefile

5927041

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

stmpe-ts: add invert/swap options

1549e52

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

stmpe-ts.c: add offsets

7705bbe

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

backports: vl53l0x: from: linux.git

57f41ae

Reference: v5.0.21 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

wire up VL53L0X_I2C

b686f2d

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

backports: brcm80211: from: linux.git

12309d5

Reference: v4.14.77 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

brcmfmac: Set F2 blksz and Watermark to 256 for 4373

9c13464

We got SDIO_CRC_ERROR with 4373 on SDR104 when doing bi-directional throughput test. Setting F2 blocksize and enable watermark to 256 to guarantee the operation stability. Signed-off-by: Wright Feng <wright.feng@cypress.com>

brcmfmac: Add support for CYW43012 SDIO chipset

9581521

CYW43012 is a 1x1 802.11a/b/g/n Dual-Band HT20, 256-QAM/Turbo QAM. It is an Ultra Low Power WLAN+BT combo chip. Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>

brcmfmac: Saverestore support changes for 43012

70adfd4

Saverestore register settings for 43012. Signed-off-by: Praveen Babu Chandran <pucn@cypress.com>

brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

20483ac

This patch will add 43455 into the save-restore(SR) capable chip list, so the SR engine will be enabled with 43455 FW which built-in the -sr function. Signed-off-by: Lo-Hsiang Lo <double.lo@cypress.com>

brcmfmac: DS1 Exit should re download the firmware.

e25a088

In Deep Sleep mode ARM is off and once Exit trigger comes than Mail Box Interrupt comes to Host and whole Re Initiation should be done in the ARM to start TX/RX. Signed-off-by: Naveen Gupta <nagu@cypress.com>

brcmfmac: add FT-based AKMs in brcmf_set_key_mgmt() for FT support

760eebf

Add WLAN_AKM_SUITE_FT_8021X and WLAN_AKM_SUITE_FT_PSK in brcmf_set_key_mgmt() for FT support. Signed-off-by: Chung-Hsien Hsu <stanley.hsu@cypress.com> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>

brcmfmac: do not print ulp_sdioctrl get error

fd3ec58

Don't print ulp_sdioctrl get error as errors are expected for non ulp cases. Signed-off-by: Naveen Gupta <nagu@cypress.com>

brcmfmac: Remove WOWL configuration in disconnect state

ea8ba1b

Set wowl configuration in disconnect state is redundant. Remove it to fix no scan result issue after resume. Signed-off-by: Lo-Hsiang Lo <double.lo@cypress.com>

RobertCNelson and others added 18 commits May 15, 2020 13:20

hack: gpiolib: yes we have drivers stomping on each other...

849a0b7

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

uio: add uio_pruss_shmem driver

0630bc2

Signed-off-by: Jason Kridner <jdk@ti.com>

drm/adihdmi: Drop dummy save/restore hooks

bde6393

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

drm/adihdmi: Pass 'name' to drm_encoder_init()

92dac91

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

adihdmi_drv: reg_default -> reg_sequence

0c7b982

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

adihdmi_drv fix drm_of.h include

c47eb9d

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

of: overlay: remove sysfs_create_groups call

d1f107c

This crashes the kernel when an runtime overlay is applied.

bootup hacks: move mmc early

7a5f5f1

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

bootup-hacks: xor select neon or arm4regs

0f56af2

already default on BBB/X15, just calcuated everybootup Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

backports: bindeb-pkg: from: linux.git

5bc34e1

Reference: v5.2.21 Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

builddeb: Install our dtbs under /boot/dtbs/$version

f2a39ee

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

enable: Jenkins: http://gfnd.rcn-ee.org:8080

8fdd648

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

4.14.108-ti-r135 patchset

e58bcee

GSoC warm up task

834df44

dlech reviewed Jun 6, 2020

View reviewed changes

fix file operation namings

24ef54c

RobertCNelson force-pushed the 4.14 branch from 95c38f2 to 2a8a6a1 Compare June 8, 2020 15:23

RobertCNelson force-pushed the 4.14 branch from 2a8a6a1 to d997583 Compare August 24, 2020 23:19

RobertCNelson force-pushed the 4.14 branch 2 times, most recently from cf8aa20 to 6ab314d Compare March 18, 2021 19:07

RobertCNelson force-pushed the 4.14 branch from 6ab314d to c807c37 Compare March 30, 2021 23:18

RobertCNelson force-pushed the 4.14 branch from c807c37 to 1222992 Compare May 13, 2021 22:16

RobertCNelson force-pushed the 4.14 branch 2 times, most recently from bf0870f to 36b21ce Compare May 27, 2021 19:54

RobertCNelson force-pushed the 4.14 branch from 36b21ce to 19af92a Compare December 23, 2021 23:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GSoC warm up task #236

GSoC warm up task #236

Uh oh!

lorforlinux commented Jun 6, 2020

Uh oh!

dlech left a comment

Uh oh!

dlech Jun 6, 2020

Uh oh!

lorforlinux Jun 6, 2020

Uh oh!

dlech Jun 6, 2020

Uh oh!

lorforlinux Jun 6, 2020

Uh oh!

dlech Jun 6, 2020

Uh oh!

lorforlinux Jun 6, 2020

Uh oh!

dlech Jun 6, 2020

Uh oh!

dlech Jun 6, 2020

Uh oh!

Uh oh!

GSoC warm up task #236

Are you sure you want to change the base?

GSoC warm up task #236

Uh oh!

Conversation

lorforlinux commented Jun 6, 2020

Uh oh!

dlech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!