Skip to content

Conversation

@justinas-b
Copy link

No description provided.

Copy link
Owner

@bdangit bdangit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good so far. Can you check out my comment?

Copy link
Owner

@bdangit bdangit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Copy link
Owner

@bdangit bdangit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit. Can you please squash commits?

@bdangit
Copy link
Owner

bdangit commented Sep 1, 2019

gentle reminder for @justinas-b. Can you please squash commits and then we'll be okay to merge.

@justinas-b
Copy link
Author

Hi @bdangit, sorry but it seems I have lost my forked repo, so I am unable to do the squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants