Skip to content

remove trigger from deployment doc #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Conversation

ShellyXueHan
Copy link
Contributor

@ShellyXueHan ShellyXueHan commented May 21, 2025

Since there's no more trigger spec in deployment (not like deploymentConfig), updating the doc to include the annotation trigger method.

@ShellyXueHan ShellyXueHan requested review from Pilargit12 and mtspn May 21, 2025 18:03
Copy link
Contributor

@Pilargit12 Pilargit12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Shelly, I do not see anything from my end needing to be changed.

Copy link
Contributor

@Pilargit12 Pilargit12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know what you think of the suggested change

Co-authored-by: Pilar Solares <131301244+Pilargit12@users.noreply.github.com>
@ShellyXueHan ShellyXueHan merged commit 040a05b into main May 22, 2025
3 checks passed
@ShellyXueHan ShellyXueHan deleted the deployment-no-trigger branch May 22, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants