Skip to content

27277 - Update postman collection with affiliation and delegation #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AimeeGao
Copy link
Contributor

@AimeeGao AimeeGao commented Apr 23, 2025

Issue #: /bcgov/entity#27277

Description of changes:

  • Updated Postman Collection - adding request URL & payloads for affiliation & delegation
  • Updated the env file
  • Updated the page history to reflect affiliation & delegation flows updates

image

@argush3
Copy link
Collaborator

argush3 commented Apr 24, 2025

/gcbrun

@argush3
Copy link
Collaborator

argush3 commented Apr 24, 2025

image

typo

@argush3
Copy link
Collaborator

argush3 commented Apr 24, 2025

image

Don't believe point 2(^^) is true. i.e. the check of whether a specific business identifier is linked to a given account can only be done against the account your api key is associated with. Maybe we can just update point 2 to not use "any account"

@argush3
Copy link
Collaborator

argush3 commented Apr 24, 2025

Can we add a note to the "IV. Affiliation & Delegation" readme section in the postman collection to just indicate that although we reference Law Firms and Vendors specifically it's just because it is a use case that has been brought up.

@argush3
Copy link
Collaborator

argush3 commented Apr 24, 2025

image

For the first bullet point, we should update this as it can apply for migrated corps or corps created in the modernized system.

@argush3 argush3 requested a review from eason-pan-bc April 24, 2025 15:01
@AimeeGao
Copy link
Contributor Author

image

Don't believe point 2(^^) is true. i.e. the check of whether a specific business identifier is linked to a given account can only be done against the account your api key is associated with. Maybe we can just update point 2 to not use "any account"

That's a great point. Agreed, it’s misleading to say any account. will update the title to Check if the corp is already affiliated

@argush3
Copy link
Collaborator

argush3 commented Apr 24, 2025

/gcbrun

Copy link
Contributor

@eason-pan-bc eason-pan-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@argush3 argush3 merged commit 0bba549 into bcgov:main Apr 24, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants