Skip to content

26557 - Developer Site - Document and demonstrate affiliation flows via API #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 7, 2025
Merged

26557 - Developer Site - Document and demonstrate affiliation flows via API #216

merged 23 commits into from
May 7, 2025

Conversation

seeker25
Copy link
Collaborator

@seeker25
Copy link
Collaborator Author

WIP still doing documentation/testing for affiliation Invitations

@seeker25
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-216-3y8lnolq.web.app

@seeker25
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-216-3y8lnolq.web.app

@seeker25
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-216-3y8lnolq.web.app

@seeker25
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-216-3y8lnolq.web.app

@seeker25
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-216-3y8lnolq.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-216-1rab2k64.web.app

@seeker25 seeker25 mentioned this pull request May 1, 2025
Closed
@seeker25
Copy link
Collaborator Author

seeker25 commented May 5, 2025

/gcbrun

@seeker25
Copy link
Collaborator Author

seeker25 commented May 5, 2025

/gcbrun

@seeker25
Fix unit test, have products alphabetical (SBC Connect needs to be ab…
5f0e571 
…ove STRR). Doesn't seem to impact Get Started etc.
@seeker25
Copy link
Collaborator Author

seeker25 commented May 6, 2025

/gcbrun

@seeker25
Copy link
Collaborator Author

seeker25 commented May 6, 2025

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-216-1rab2k64.web.app

@seeker25
Copy link
Collaborator Author

seeker25 commented May 6, 2025 •
edited
Loading

Need to revert the /affiliation call and update it so it works with the "old way"

Means we'll have to change the response as well

@seeker25
Copy link
Collaborator Author

seeker25 commented May 6, 2025

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-216-1rab2k64.web.app

@seeker25
Copy link
Collaborator Author

seeker25 commented May 6, 2025

Before merging have to take out TEST environment from spec (only sandbox and prod)

ochiu
ochiu approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@ochiu ochiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out!

Jxio
Jxio approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@Jxio Jxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AimeeGao
AimeeGao reviewed May 6, 2025
View reviewed changes
@seeker25
Copy link
Collaborator Author

seeker25 commented May 6, 2025

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-216-1rab2k64.web.app

thorwolpert
thorwolpert approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition and changes

@seeker25 seeker25 merged commit 42353a7 into main May 7, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AimeeGao AimeeGao AimeeGao left review comments

@thorwolpert thorwolpert thorwolpert approved these changes

@ochiu ochiu ochiu approved these changes

@Jxio Jxio Jxio approved these changes

@deetz99 deetz99 Awaiting requested review from deetz99 deetz99 is a code owner

@kris-daxiom kris-daxiom Awaiting requested review from kris-daxiom kris-daxiom is a code owner

@kialj876 kialj876 Awaiting requested review from kialj876 kialj876 is a code owner

@pwei1018 pwei1018 Awaiting requested review from pwei1018 pwei1018 is a code owner

@eason-pan-bc eason-pan-bc Awaiting requested review from eason-pan-bc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seeker25 @bcregistry-sre @thorwolpert @ochiu @Jxio @AimeeGao