Skip to content

24998 - Replace API Gateway with Developer Site #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

sameer0422
Copy link
Collaborator

@sameer0422
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-182-y21s83b9.web.app

@sameer0422 sameer0422 requested a review from kialj876 February 5, 2025 20:14
Copy link
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a comment on the BCOnline branding still being in there

@sameer0422
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-182-y21s83b9.web.app

Copy link
Collaborator

@deetz99 deetz99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on that one class binding but other than that looks good to me 👍

@sameer0422 sameer0422 merged commit 7172dc3 into bcgov:main Feb 10, 2025
8 of 10 checks passed
@sameer0422 sameer0422 deleted the 24998-page-title branch February 10, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants