Skip to content

Conversation

@swcurran
Copy link
Contributor

Adds the City of Vancouver as an issuer (parallel to bcgov-digital-trust) and its Rental Property Business Licence VC -- for Testing.

Logos are included in the repo and referenced in the branding overlay.

Likely should check who should be authorized to approve updates to the OCA Bundle -- I've guessed at contacts for now.

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Contributor Author

FYI @krobinsonca . Please coordinate the review with those that are appropriate. Once merged, this should be picked up by the BC Wallet -- and be visible on the https://bcgov.github.io/aries-oca-bundles/ site.

The data I was given did not specify the Primary/Secondary fields, so I used the Licence Number and Family Name from the credential. That should be verified -- let me know if changes are needed. Likewise the contacts in the README.md file.

@mathieuglaude
Copy link

mathieuglaude commented Aug 21, 2025

Thanks @swcurran. Some comments:

  1. I may have mis-tagged certain attributes in the Excel spreadsheet. I meant to tag 'business_trade_name' and 'business_sub_type' as the primary and secondary attributes. I got confused with the 'Flagged' column.
  2. Regarding the 'Flagged' column for PII - your assessment is correct, only the Given and Family Names. I would also flag the address attributes as well though (Unit / unit_type / street_number / street_name / municipality / municipality_status / regional_district / province_territory / postal_code / Country), as the address-related fields can be PII when they point to a specific individual’s residence or property.
  3. You can add my name as a contact on the OCA. (Mathieu Glaude, mathieu@northernblock.io, @mathieuglaude)

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Contributor Author

PR has been updated per @mathieuglaude 's comments.

Copy link
Contributor

@krobinsonca krobinsonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved for DEV

@swcurran swcurran merged commit e379299 into bcgov:main Aug 22, 2025
1 check passed
@swcurran swcurran deleted the cov-property-rental-license branch September 11, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants