Updated LTSA logo, added attributes to OCA, and updated Excel file wi…

[arbordeleau]

I have updated my repo and closed the other pull request!

1. Updated the LTSA logo.
2. Added the primary and secondary attributes.
3. Modified the Excel file to display the "DEMONSTRATION" watermark in the Meta Overlay section.

[swcurran]

Ooopppss…the DCO was not applied. Please apply. The changes are approved, but can’t be merged until the DCO is done.

Looks good other than that.

[arbordeleau]

Ok done! Sorry learning new things everyday with Github :-)

[arbordeleau]

Are the changes will be shown in the BC Wallet? Seems like the attributes and the logo is still missing

[swcurran]

The second PR I put in needs to be approved and merged — looking for someone to do that. #154

[swcurran]

Sorry - I meant #154

[arbordeleau]

Ahh ok! Sorry no rush :)

…

On Wed, Dec 11, 2024 at 3:33 PM Stephen Curran ***@***.***> wrote: Sorry - I meant #154 <#154> — Reply to this email directly, view it on GitHub <#153 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVSFOAPBR6K7M44PF2AYKU32FCOQXAVCNFSM6AAAAABTOHPI6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXGA3TMOJQGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- *Ariane Bordeleau* (581) 989-6918 arianebordeleau.com ***@***.***

[arbordeleau]

Sorry to ask again.. but we've been testing with the BC Wallet LTSA credential and the attributes name are only showing in french even if my app is in english and my phone settings are in english.. Is it possible to help me understand where the issue come from? I have checked the excel file and it seems to be all in the right places.

[swcurran]

Weird — let me look. I’ve not been looking at the details of the content — just the structure.

[swcurran]

Looks good here, I think: https://bcgov.github.io/aries-oca-bundles/OCABundles/schema/bcgov-digital-trust/LTSA/NewCredCredential/demo/#credential-appearance

[swcurran]

This is a question for the BC Wallet team — @cvarjao and team. From above — the LTSA text is showing up in French, regardless of the language setting on the phone (app?).

In comparing the LTSA OCABundle.json and the BC Person OCABundle the difference I see is that the language codes are “fr-CA” and “en-CA” (LTSA) and “fr” and “en” (Person).

@cvarjao — is that the issue? Or is it something else?

[cvarjao]

At the moment, BC Wallet only supports the en language code. Also, we do not do any
https://github.com/bcgov/bc-wallet-mobile/blob/66e2955134012da9dfaab8f0fe33f7eae2ff9bff/app/container-imp.ts#L221
If no exact match is found, the wallet default to the first label overlay defined.

We only do a exact match, so I suggest we stick with 2-letters ISO 639-1 code. OCA Spec says:

The language attribute MUST contain either the two-letter language code (lowercase) for a national language or the combined language (lowercase)/country (uppercase) code for a regional language or locale.

we only support the two-letter language code at the moment, we could expand to support both, and define some fallback rules.