Pass -no_warning_for_no_symbols flag to libtool on macos #503
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the default in Bazel before starlarkification, and also the default in apple_support now.
cerisier
requested review from
armandomontanez,
c-mita,
comius,
hvadehra,
pzembrod and
trybka
as code owners
armandomontanez
previously approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Two notes:
- IMO should do this, it makes the behavior of libtool closer to ar. 👍
- I haven't met anyone that feels this error is worth leaving enabled, but it still might be good to file bugs against or fix the sites you've encountered that do this. Status quo is not to create a linking context if no files are being compiled. bazelbuild/bazel#18095
| name = "no_warning_for_no_symbols", | ||
| actions = ["//cc/toolchains/actions:ar_actions"], | ||
| args = select({ | ||
| ":use_libtool_on_macos_setting": ["-no_warning_for_no_symbols"], |
There was a problem hiding this comment.
Nit: -no_warning_for_no_symbols can be moved into create_static_archive below, next to -static.
There was a problem hiding this comment.
Thanks for the review. I'll move that down. There is also the -D which sets default to userid, groupid, modes etc.. I can make a second PR for that.
keith
reviewed
Oct 27, 2025
| name = "no_warning_for_no_symbols", | ||
| actions = ["//cc/toolchains/actions:ar_actions"], | ||
| args = select({ | ||
| ":use_libtool_on_macos_setting": ["-no_warning_for_no_symbols"], |
There was a problem hiding this comment.
instead of creating a separate cc_args for this i would just include this with -static below
armandomontanez
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the default in Bazel before Starlarkification.