Only use hardlinks in rctx.download_and_extract
#27453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
27446-no-download-hardlink
branch
2 times, most recently
from
eb91168 to
bf9c6b5
Compare
|
@bazel-io fork 8.5.0 |
github-actions
bot
added
team-ExternalDeps
The repo rule may modify the file downloaded via `rctx.download`, so it isn't safe to hardlink it. In the future, when `FileSystemUtils.copyFile` is backed by Java's `Files.copy`, copying can reflink and thus recover the performance gain without using hardlinks.
fmeum
force-pushed
the
27446-no-download-hardlink
branch
from
bf9c6b5 to
3f1533a
Compare
|
@meteorcloudy FYI, the reflink optimization: #27459 |
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Oct 30, 2025
The repo rule may modify the file downloaded via `rctx.download`, so it isn't safe to hardlink it. In the future, when `FileSystemUtils.copyFile` is backed by Java's `Files.copy`, copying can reflink and thus recover the performance gain without using hardlinks. Related to bazelbuild#27446 Closes bazelbuild#27453. PiperOrigin-RevId: 825941868 Change-Id: I7764b142724b16c4a9d7694af066105bc7b76575
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
The repo rule may modify the file downloaded via `rctx.download`, so it isn't safe to hardlink it. In the future, when `FileSystemUtils.copyFile` is backed by Java's `Files.copy`, copying can reflink and thus recover the performance gain without using hardlinks. Related to #27446 Closes #27453. PiperOrigin-RevId: 825941868 Change-Id: I7764b142724b16c4a9d7694af066105bc7b76575 Commit 957129f Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo rule may modify the file downloaded via
rctx.download, so it isn't safe to hardlink it.In the future, when
FileSystemUtils.copyFileis backed by Java'sFiles.copy, copying can reflink and thus recover the performance gain without using hardlinks.Related to #27446