Skip to content

rules_gleam@0.1.13 #6298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rules_gleam@0.1.13 #6298

wants to merge 1 commit into from
+93 −1

Conversation

@iocat
Copy link
Contributor

@iocat iocat commented Oct 26, 2025

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules (rules_gleam) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 26, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 0.1.13 of rules_gleam. The changes are mostly correct and follow the Bazel Central Registry policies. However, I've identified several issues related to build hermeticity and reproducibility in presubmit.yml and MODULE.bazel that should be addressed. Using latest tags for dependencies and modifying the build environment can lead to non-reproducible builds for downstream users, which goes against a core principle of the BCR. Please see my detailed comments for suggestions on how to fix these issues.

bazel-io
bazel-io previously approved these changes Oct 26, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@iocat iocat force-pushed the rules_gleam-v0.1.13 branch from 53f0592 to b29dbbe Compare October 26, 2025 04:29
@bazel-io bazel-io dismissed their stale review October 26, 2025 04:30

Require module maintainers' approval for newly pushed changes.

bazel-io
bazel-io previously approved these changes Oct 26, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@iocat iocat force-pushed the rules_gleam-v0.1.13 branch from b29dbbe to b300d66 Compare October 26, 2025 07:46
@bazel-io bazel-io dismissed their stale review October 26, 2025 07:46

Require module maintainers' approval for newly pushed changes.

bazel-io
bazel-io approved these changes Oct 26, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bazel-io bazel-io bazel-io approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iocat @bazel-io