libdwarf@2.2.0 #6287
libdwarf@2.2.0 #6287
Conversation
|
Hello @vtsao-openai, modules you maintain (libdwarf) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds version 2.2.0 of libdwarf. The changes are well-structured and generally follow the Bazel Central Registry guidelines. I've identified one issue in the BUILD.bazel file where source files are incorrectly included in the hdrs attribute of a cc_library, which should be corrected.
| hdrs = glob( | ||
| [ | ||
| "src/bin/dwarfdump/*.h", | ||
| "src/bin/dwarfdump/*.c", | ||
| ], | ||
| ), |
There was a problem hiding this comment.
Source files (.c) should not be included in the hdrs attribute of a cc_library. The hdrs attribute is for header files that are part of the library's public interface. Including source files can lead to multiple definition errors and unnecessarily exposes implementation details. These source files are already correctly listed in the srcs attribute.
hdrs = glob(["src/bin/dwarfdump/*.h"]),
2 participants
No description provided.