Skip to content

Conversation

@aaliddell
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules (rules_proto_grpc, rules_proto_grpc_buf, rules_proto_grpc_cpp, rules_proto_grpc_csharp, rules_proto_grpc_doc, rules_proto_grpc_go, rules_proto_grpc_grpc_gateway, rules_proto_grpc_java, rules_proto_grpc_js, rules_proto_grpc_objc, rules_proto_grpc_python, rules_proto_grpc_scala, rules_proto_grpc_swift) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@aaliddell
Copy link
Contributor Author

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Oct 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 5.8.0 for rules_proto_grpc and its related modules. The changes are mostly boilerplate for the new version, including MODULE.bazel, presubmit.yml, and source.json files for each module, and updating the corresponding metadata.json. The changes look good overall, but I've found critical dependency version inconsistencies in the rules_proto_grpc_java module related to protobuf and grpc that will likely cause issues for downstream users. Please see the detailed comments.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@bazel-io bazel-io merged commit 3c7fad7 into bazelbuild:main Oct 23, 2025
60 checks passed
@bazel-io bazel-io added the auto-merged This PR is automatically merged by the BCR reviewer bot. label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merged This PR is automatically merged by the BCR reviewer bot. skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants