feat: add glfw 3.4 #6282
Merged
feat: add glfw 3.4 #6282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wep21
commented
Oct 23, 2025
wep21
commented
- add glfw 3.4
- make linux target hermetic
|
Hello @Vertexwahn, @phaedon, modules you maintain (glfw) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for glfw version 3.4.0. The overall structure is correct and follows the Bazel Central Registry guidelines. I've identified two issues in the BUILD.bazel overlay file: an incorrect header file included for the macOS build, and a missing dependency for the Linux build. Addressing these will ensure the module builds correctly on all supported platforms.
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Vertexwahn
approved these changes
Oct 23, 2025
bazel-io
approved these changes
Oct 23, 2025
|
@meteorcloudy @fmeum @kotlaja please unblock presubmit ci. |
fmeum
added
the
presubmit-auto-run
bazel-io
added
the
auto-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.