-
Notifications
You must be signed in to change notification settings - Fork 575
Add openconfig_bootz@0.6.1 #6254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bazel-io skip_check unstable_url |
|
Hello @marcushines, modules you maintain (openconfig_bootz) have been updated in this PR. |
|
@bazel-io skip_check incompatible_flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds version 0.6.1 of the openconfig_bootz module to the Bazel Central Registry. The file structure and metadata changes are correct for adding a new module version. However, there is a critical issue in the MODULE.bazel file where multiple dependencies are declared with versions that do not appear to exist, which will cause the presubmit checks to fail. These versions must be corrected for the module to be usable.
| bazel_dep(name = "gazelle", version = "0.45.0", repo_name = "bazel_gazelle") | ||
| bazel_dep(name = "grpc", version = "1.74.1", repo_name = "com_github_grpc_grpc") | ||
| bazel_dep(name = "protobuf", version = "32.1", repo_name = "com_google_protobuf") | ||
| bazel_dep(name = "rules_go", version = "0.57.0", repo_name = "io_bazel_rules_go") | ||
| bazel_dep(name = "openconfig_gnmi", version = "0.14.1") | ||
| bazel_dep(name = "openconfig_gnsi", version = "1.9.0") | ||
|
|
||
| go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") | ||
| go_sdk.download(version = "1.25.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions specified for several dependencies do not appear to be valid, released versions and will cause dependency resolution to fail. Please correct them to valid, existing versions.
Here are some of the versions that appear to be incorrect:
gazelle@0.45.0: This version does not seem to exist. The latest known version in BCR is0.37.0.grpc@1.74.1: This version does not seem to exist. The latest known version is1.65.1.protobuf@32.1: This version does not seem to exist. The latest known version in BCR is25.1.rules_go@0.57.0: This version does not seem to exist. The latest known version is0.47.1.go_sdk@1.25.1: This version of the Go SDK is not yet released. The latest stable Go version is in the1.22.xseries.openconfig_gnmi@0.14.1: This version is not in BCR. The latest is0.10.0.openconfig_gnsi@1.9.0: This version is not in BCR. The latest is1.4.0.
|
@bazelbuild/bcr-maintainers can the presubmit.yml change be approved to run CI? |
No description provided.