Skip to content

Conversation

@bstoll
Copy link
Contributor

@bstoll bstoll commented Oct 20, 2025

No description provided.

@bstoll
Copy link
Contributor Author

bstoll commented Oct 20, 2025

@bazel-io skip_check unstable_url

@bazel-io
Copy link
Member

Hello @marcushines, modules you maintain (openconfig_bootz) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Oct 20, 2025
@bstoll
Copy link
Contributor Author

bstoll commented Oct 20, 2025

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Oct 20, 2025
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 0.6.1 of the openconfig_bootz module to the Bazel Central Registry. The file structure and metadata changes are correct for adding a new module version. However, there is a critical issue in the MODULE.bazel file where multiple dependencies are declared with versions that do not appear to exist, which will cause the presubmit checks to fail. These versions must be corrected for the module to be usable.

Comment on lines +6 to +14
bazel_dep(name = "gazelle", version = "0.45.0", repo_name = "bazel_gazelle")
bazel_dep(name = "grpc", version = "1.74.1", repo_name = "com_github_grpc_grpc")
bazel_dep(name = "protobuf", version = "32.1", repo_name = "com_google_protobuf")
bazel_dep(name = "rules_go", version = "0.57.0", repo_name = "io_bazel_rules_go")
bazel_dep(name = "openconfig_gnmi", version = "0.14.1")
bazel_dep(name = "openconfig_gnsi", version = "1.9.0")

go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk")
go_sdk.download(version = "1.25.1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The versions specified for several dependencies do not appear to be valid, released versions and will cause dependency resolution to fail. Please correct them to valid, existing versions.

Here are some of the versions that appear to be incorrect:

  • gazelle@0.45.0: This version does not seem to exist. The latest known version in BCR is 0.37.0.
  • grpc@1.74.1: This version does not seem to exist. The latest known version is 1.65.1.
  • protobuf@32.1: This version does not seem to exist. The latest known version in BCR is 25.1.
  • rules_go@0.57.0: This version does not seem to exist. The latest known version is 0.47.1.
  • go_sdk@1.25.1: This version of the Go SDK is not yet released. The latest stable Go version is in the 1.22.x series.
  • openconfig_gnmi@0.14.1: This version is not in BCR. The latest is 0.10.0.
  • openconfig_gnsi@1.9.0: This version is not in BCR. The latest is 1.4.0.

@bstoll
Copy link
Contributor Author

bstoll commented Oct 21, 2025

@bazelbuild/bcr-maintainers can the presubmit.yml change be approved to run CI?

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 21, 2025
@bazel-io bazel-io merged commit a50c7cb into bazelbuild:main Oct 21, 2025
14 checks passed
@bazel-io bazel-io added the auto-merged This PR is automatically merged by the BCR reviewer bot. label Oct 21, 2025
@bstoll bstoll deleted the bootz-release branch October 22, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merged This PR is automatically merged by the BCR reviewer bot. presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants