Skip to content

Conversation

@bazel-contrib-bot
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @rickeylev, @aignas, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@rickeylev
Copy link
Contributor

@bazelbuild/bcr-maintainers presubmit has been changed; needs maintainer to approve and trigger CI

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 20, 2025
@Wyverald
Copy link
Member

@rickeylev @meteorcloudy the problem described in #6220 seems to persist. I can help look into it a bit later today if you don't get to it before me.

@rickeylev
Copy link
Contributor

Hrm. I thought the shell_commands part of the presubmit fixed that; In #6219 I managed to get presubmits happy.

idea: maybe shell_commands needs to write to gazelle/examples/bzlmod_build_file_generation instead of the PWD?

@meteorcloudy
Copy link
Member

meteorcloudy commented Oct 22, 2025

In #6219, the MODULE.bazel file had local_path_override for rules_python commented out:

# The following loads rules_python from the file system.
# For usual setups you should remove this local_path_override block.
## local_path_override(
##     module_name = "rules_python",
##     path = "../../../asdf",
## )

So basically --override_module=rules_python= doesn't override the local_path_override, but if you convert local_path_override to --override_module=rules_python=../../.. in the .bazelrc file, the one in presubmit.yml will be able to override it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants