Skip to content

add emsdk 4.0.17 #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2025
Merged

add emsdk 4.0.17 #6238

merged 2 commits into from
Oct 20, 2025

Conversation

@DoDoENT
Copy link
Contributor

@DoDoENT DoDoENT commented Oct 19, 2025

No description provided.

@DoDoENT
Copy link
Contributor Author

DoDoENT commented Oct 19, 2025

@bazel-io skip_check unstable_url

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (emsdk) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Oct 19, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 19, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 4.0.17 for the emsdk module. The changes are well-structured and follow the Bazel Central Registry guidelines, including adding the necessary MODULE.bazel, source.json, and presubmit.yml files, and updating metadata.json. I've provided a couple of suggestions to improve maintainability by reducing duplication in the presubmit.yml configuration and consolidating use_repo calls in MODULE.bazel. Overall, this is a good contribution.

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 20, 2025
meteorcloudy
meteorcloudy previously approved these changes Oct 20, 2025
View reviewed changes
@meteorcloudy meteorcloudy enabled auto-merge (squash) October 20, 2025 09:12
auto-merge was automatically disabled October 20, 2025 09:18

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed meteorcloudy’s stale review October 20, 2025 09:18

Require module maintainers' approval for newly pushed changes.

@kotlaja kotlaja merged commit b332fb3 into bazelbuild:main Oct 20, 2025
18 checks passed
FilipposSot pushed a commit to FilipposSot/bazel-central-registry that referenced this pull request Oct 20, 2025
@DoDoENT @FilipposSot
add emsdk 4.0.17 (bazelbuild#6238)
c449840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kotlaja kotlaja kotlaja approved these changes

@meteorcloudy meteorcloudy meteorcloudy left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DoDoENT @bazel-io @meteorcloudy @kotlaja