aspect_rules_js@2.7.0 #6237
aspect_rules_js@2.7.0 #6237
Conversation
|
Hello @alexeagle, @gregmagolan, @jbedard, modules you maintain (aspect_rules_js) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds version 2.7.0 of aspect_rules_js. The changes are mostly correct and follow the Bazel Central Registry guidelines. However, there is one critical issue: the homepage field has been removed from metadata.json. Per BCR policy, changes must be add-only, and modifying existing files beyond what's necessary to add the new version is not allowed. Please restore the homepage field.
| @@ -1,5 +1,4 @@ | |||
| { | |||
| "homepage": "https://docs.aspect.build/rules/aspect_rules_js", | |||
There was a problem hiding this comment.
The homepage field should not be removed. The Bazel Central Registry is an append-only repository, and existing files should not be modified except to add a new version.1 Please restore this field.
Style Guide References
Footnotes
-
The BCR is add-only. Pull requests should not mutate existing module versions or non-module files when adding a new version. ↩
There was a problem hiding this comment.
The metadata file is not immutable, only versioned files are
bazel-io
dismissed stale reviews from fmeum, jbedard, and themself
Require module maintainers' approval for newly pushed changes.
bazel-io
dismissed
alexeagle’s stale review
Require module maintainers' approval for newly pushed changes.
|
@bazel-io skip_check incompatible_flags |
bazel-io
added
the
skip-incompatible-flags-test
Head branch was pushed to by a user without write access
bazel-io
dismissed stale reviews from alexeagle and themself
Require module maintainers' approval for newly pushed changes.
Wyverald
added
the
presubmit-auto-run
6 participants
Release: https://github.com/aspect-build/rules_js/releases/tag/v2.7.0
Automated by Publish to BCR