feat: add some x extensions #6233

wep21 · 2025-10-17T16:38:02Z

No description provided.

bazel-io · 2025-10-17T16:38:27Z

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libxext) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

wep21 · 2025-10-17T16:39:07Z

@bazel-io skip_check unstable_url

gemini-code-assist

Code Review

This pull request adds the libxext module version 1.3.6 to the Bazel Central Registry. The changes are well-structured, but I have identified two high-severity issues that should be addressed. First, the repository field in metadata.json should point to the canonical upstream repository. Second, the version parsing logic in the BUILD.bazel overlay is not robust and could fail with different version formats. Please see the detailed comments for suggestions.

modules/libxext/1.3.6/overlay/BUILD.bazel

modules/libxext/metadata.json

wep21 · 2025-10-17T16:40:21Z

@fmeum @meteorcloudy @Wyverald @kotlaja please add presubmit auto run label to check ci build.

bazel-io · 2025-10-18T08:59:33Z

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libxext, libxfixes) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-18T09:06:15Z

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libxext, libxfixes, libxrender) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

kotlaja · 2025-10-20T14:11:50Z

@wep21 this seems ready for review?

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

bazel-io · 2025-10-20T14:23:16Z

Hello @bazelbuild/bcr-maintainers, modules (libx11) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 · 2025-10-20T14:25:24Z

@kotlaja I'm sorry, but I'm still working in progress.

kotlaja · 2025-10-20T14:30:22Z

No worries, take your time. Let me know when it's ready :)

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

bazel-io · 2025-10-20T16:29:39Z

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libxcursor, libxext, libxfixes, libxrender) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

bazel-io · 2025-10-20T16:41:50Z

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libxcursor, libxext, libxfixes, libxi, libxrender) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

bazel-io · 2025-10-20T16:52:33Z

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libxcursor, libxext, libxfixes, libxi, libxinerama, libxrender) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

bazel-io · 2025-10-20T17:00:19Z

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libxcursor, libxext, libxfixes, libxi, libxinerama, libxrandr, libxrender) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 · 2025-10-20T17:07:35Z

@kotlaja @meteorcloudy @fmeum Now ready to review. All ci errors come from unrelated 403 error.

kotlaja

Can you add some documentation for the relatively-large overlays?

See bcr-policies.md:

* When a PR contains C++ modules with large BUILD overlays, ask for some documentation on how these BUILD files are created.
    * Such documentation can either be in a README.md file under the module directory, or simply be some comments in the BUILD overlays.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 · 2025-10-20T17:32:39Z

@shameekganguly I appreciate it if you could review this PR.

shameekganguly · 2025-10-20T17:49:12Z

modules/libxfixes/6.0.2/patches/fix_include.patch

+ #include <X11/Xlib.h>
+ #include <X11/Xlibint.h>
+ #include <X11/Xutil.h>
+-#include "Xfixes.h"


Is this really necessary? Xfixes.h is declared in the hdrs attribute of the same bazel target as this header file. So I'd expect quotes to work as well as long as include/X11/extensions is listed in the includes attribute?

ERROR: /Users/daisuke/workspace/libxfixes/BUILD.bazel:24:11: Compiling src/SaveSet.c failed: undeclared inclusion(s) in rule '//:xfixes': this rule is missing dependency declarations for the following files included by 'src/SaveSet.c': 'bazel-out/darwin_arm64-fastbuild/bin/external/libxcb+/Xfixes.h' ERROR: /Users/daisuke/workspace/libxfixes/BUILD.bazel:24:11: Compiling src/Selection.c failed: undeclared inclusion(s) in rule '//:xfixes': this rule is missing dependency declarations for the following files included by 'src/Selection.c': 'bazel-out/darwin_arm64-fastbuild/bin/external/libxcb+/Xfixes.h'

Something confusing occurs with Xfixes.h of libxcb in macos environement.

Ah, this is coming from the apple file system being case-insensitive, so there is a contention between @libxcb//src/xfixes.h and include/X11/extensions/Xfixes.h within this repo.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

shameekganguly · 2025-10-20T17:50:41Z

modules/libxi/1.8.2/overlay/BUILD.bazel

+            "src/*.c",
+            "src/*.h",
+        ],
+        exclude = ["src/XFreeLst.c"],


nit: consider adding a comment for readability as to why XFreeLst.c is excluded from the target.

I've referred this comment. I'm not sure why, but I'll add the same comment.

wep21 · 2025-10-20T17:52:33Z

@kotlaja I've added some short notes about overlay.

shameekganguly

Left a few minor comments. But looks good overall. Thanks!

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

Require module maintainers' approval for newly pushed changes.

resolved

wep21 marked this pull request as draft October 17, 2025 16:38

bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Oct 17, 2025

gemini-code-assist bot reviewed Oct 17, 2025

View reviewed changes

modules/libxext/1.3.6/overlay/BUILD.bazel Show resolved Hide resolved

modules/libxext/metadata.json Show resolved Hide resolved

kotlaja added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 20, 2025

wep21 added 5 commits October 20, 2025 23:22

add xext

20c789f

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

add libxfixes

9943563

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

add libxrender

adbeff0

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

update

1489c55

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

update

476e7ee

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 force-pushed the add-x-extensions branch from a014bf9 to 476e7ee Compare October 20, 2025 14:23

update

12606d9

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 added 6 commits October 20, 2025 23:37

update

f1cf682

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

remove windows check in libxext

c8aa69c

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

update libxfixes

c5d6641

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

update libxfixes

24f3267

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

update libxfixes

f20c2a4

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

update libxfixes

a59e2c9

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 force-pushed the add-x-extensions branch from cb21fb0 to a59e2c9 Compare October 20, 2025 16:11

wep21 added 2 commits October 21, 2025 01:16

update libxrender

ef66509

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

add libxcursor

fa7b01e

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

add libxi

d088291

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

add libxinerama

49c2ab7

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 added 2 commits October 21, 2025 01:59

add libxinerama

eb76f7c

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

add libxrandr

5712867

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

update libxrandr

0efbd2d

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 marked this pull request as ready for review October 20, 2025 17:07

kotlaja previously requested changes Oct 20, 2025

View reviewed changes

update libx11

b55c9e4

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 mentioned this pull request Oct 20, 2025

Update libxtrans dep in libx11 and bump libx11 to 1.8.12.bcr.3 #6253

Closed

shameekganguly reviewed Oct 20, 2025

View reviewed changes

add readme for x extensions

7b9a209

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 requested a review from kotlaja October 20, 2025 17:50

shameekganguly reviewed Oct 20, 2025

View reviewed changes

shameekganguly previously approved these changes Oct 20, 2025

View reviewed changes

add comment for excluding XFreeLst.c

2a3e376

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

meteorcloudy approved these changes Oct 21, 2025

View reviewed changes

meteorcloudy merged commit b2d507c into bazelbuild:main Oct 21, 2025
126 checks passed

feat: add some x extensions #6233

feat: add some x extensions #6233

Uh oh!

Conversation

wep21 commented Oct 17, 2025

Uh oh!

bazel-io commented Oct 17, 2025

Uh oh!

wep21 commented Oct 17, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

wep21 commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bazel-io commented Oct 18, 2025

Uh oh!

bazel-io commented Oct 18, 2025

Uh oh!

kotlaja commented Oct 20, 2025

Uh oh!

bazel-io commented Oct 20, 2025

Uh oh!

wep21 commented Oct 20, 2025

Uh oh!

kotlaja commented Oct 20, 2025

Uh oh!

bazel-io commented Oct 20, 2025

Uh oh!

bazel-io commented Oct 20, 2025

Uh oh!

bazel-io commented Oct 20, 2025

Uh oh!

bazel-io commented Oct 20, 2025

Uh oh!

wep21 commented Oct 20, 2025

Uh oh!

kotlaja left a comment

Choose a reason for hiding this comment

Uh oh!

wep21 commented Oct 20, 2025

Uh oh!

shameekganguly Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

wep21 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

shameekganguly Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

shameekganguly Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

wep21 Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wep21 commented Oct 20, 2025

Uh oh!

shameekganguly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wep21 commented Oct 17, 2025 •

edited

Loading

wep21 Oct 20, 2025 •

edited

Loading