Skip to content

Conversation

@pcj
Copy link
Member

@pcj pcj commented Oct 8, 2025

Release: https://github.com/stackb/rules_closure/releases/tag/v1.0.0

Note: this is a variant / fork of https://registry.bazel.build/modules/rules_closure. That one has been stripped down of capabilities and exists mostly to serve j2cl. This one adds back the closure library, restores support for closure-templates and protobuf-javascript. As a homage to the original version I named this one io_bazel_rules_closure.

Automated by Publish to BCR

@bazel-io
Copy link
Member

bazel-io commented Oct 8, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (io_bazel_rules_closure) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the io_bazel_rules_closure module at version 1.0.0. The overall structure adheres to the Bazel Central Registry (BCR) policies. However, there is a critical issue in MODULE.bazel regarding the use of use_repo_rule that will prevent this module from being used as a dependency. Please see the detailed comment below.

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 9, 2025
)

http_file(
name = "libpng_amd64_deb",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these debs prod.dependencies? I'm asking since there is a steady volume of security issues found in these libraries and having them enter your build as an http_file dep of a ruleset would be unexpected at least for me.

Are there BCR versions of these libs that you could depend on instead?

@@ -0,0 +1,151 @@
module(
name = "io_bazel_rules_closure",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into the future, wouldn't stackb_rules_closure be a more meaningful name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for stackb_rules_closure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants