Skip to content

Don't forbid use_extension("llvm.bzl") inside non-root modules #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't forbid use_extension("llvm.bzl") inside non-root modules #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions toolchain/extensions/llvm.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ def _constraint_dict(tags, name):

def _llvm_impl_(module_ctx):
for mod in module_ctx.modules:
if not mod.is_root:
fail("Only the root module can use the 'llvm' extension")
toolchain_names = []
for toolchain_attr in mod.tags.toolchain:
if not mod.is_root:
fail("Only the root module can use the 'llvm.toolchain()' tag")
name = toolchain_attr.name
toolchain_names.append(name)
attrs = {
Expand Down