-
Notifications
You must be signed in to change notification settings - Fork 52
Update example #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! I added a PR with 2 additional commits for fixing the MAcOS build issue here Note:
Hence I added this path to the cmake. On linux this path is used by default. On MacOS apparently not. I will leave some more comments next on the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking forward for this.
src/github_actions_gtest_example.cpp
Outdated
@@ -1,4 +1,4 @@ | |||
#include <github_actions_gtest_example/github_actions_gtest_example.h> | |||
#include "github_actions_gtest_example/github_actions_gtest_example.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert. Not part of the PR issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes not part of the PR, you're right but also no because do you really want searching your own include in system paths first ? This makes sense for library for example. Have you already reverted on your patch ?
src/info.cpp
Outdated
@@ -1,4 +1,4 @@ | |||
#include <github_actions_gtest_example/github_actions_gtest_example.h> | |||
#include "github_actions_gtest_example/github_actions_gtest_example.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert. Not part of the PR issue.
@@ -1,5 +1,5 @@ | |||
#include <github_actions_gtest_example/github_actions_gtest_example.h> | |||
|
|||
#include "github_actions_gtest_example/github_actions_gtest_example.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert. Not part of the PR issue.
test/AllTests.cpp
Outdated
@@ -1,3 +1,4 @@ | |||
#include <gmock/gmock.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why bringing in gmock everywhere? Seems not to be needed, right?
I probably do not mind, but I am curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I did not reaaly look at your gtest code. My main looks like:
#include <gtest/gtest.h>
// #include <gmock/gmock.h>
int main(int argc, char *argv[])
{
// The following line must be executed to initialize Google Mock
// (and Google Test) before running the tests.
::testing::InitGoogleMock(&argc, argv);
return RUN_ALL_TESTS();
}
@bastianhjaeger |
No description provided.