feat: add ensure_bool function for robust boolean validation #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced ensure_bool function to convert various input types to boolean values, enhancing input validation. - Updated switch.py to utilize ensure_bool for configuration parameters, ensuring consistent boolean handling. - Added comprehensive unit tests for ensure_bool to cover valid and invalid cases, ensuring reliability.
for more information, see https://pre-commit.ci
|
I've opened this PR because I'm experiencing the same issue again. |
- Changed error messages in test_invalid_values and test_error_message_includes_value to use English instead of German for better clarity and consistency. - Ensured that all invalid input cases provide uniform error messaging.
…adaptive-lighting into fix/ensure-bool-config
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #919
The integration was vulnerable to string boolean values (like
"false") being passed through service calls or configuration, which could cause unexpected behavior since non-empty strings are truthy in Python.Solution
ensure_bool()utility function inhelpers.pyfor robust boolean validationChanges
ensure_bool()function with support for common boolean string representationsTesting