fix: Properly error if key is not a member of object or index of array

Author: hyperupcall

README.md

@@ -50,14 +50,11 @@ assert [ "$REPLY" = rho ]
 STATUS: IN DEVELOPMENT!
 
 ```sh
-echo "dependencies [ 'hyperupcall/bash-object' ]" > 'bpm.toml'
+echo "dependencies = [ 'hyperupcall/bash-object' ]" > 'bpm.toml'
 bpm install
 ```
 
 ## TODO
-- do not auto create tree with set (or add -p flag that does so)
-- workshop set-* functions
-- add support for set-object and set-array
 - error on invalid references (`type=object` in virtual object metadata, when it is referencing an array)
 - add tests for array in array (like object in object)
 - ensure error (for set primarily) if the virtual object references a variable that does not exist

pkg/lib/traverse-get.sh

@@ -26,21 +26,25 @@ bash_object.traverse-get() {
 	esac
 	for ((i=0; i<${#REPLIES[@]}; i++)); do
 		local key="${REPLIES[$i]}"
-		local is_index_of_array='no'
-
 		filter_stack+=("$key")
 
+		local oldIFS="$IFS"
+		IFS='_'
+		local filter_stack_string="${filter_stack[*]}"
+		IFS="$oldIFS"
+
 		bash_object.trace_loop
 
+		local is_index_of_array='no'
 		if [ "${key::1}" = $'\x1C' ]; then
 			key="${key#?}"
 			is_index_of_array='yes'
 		fi
 
 		# If 'key' is not a member of object or index of array, error
 		if [ -z "${current_object["$key"]+x}" ]; then
-			echo "Error: Key '$key' is not in object '$current_object_name'"
-			return 1
+			bash_object.util.die 'ERROR_VALUE_NOT_FOUND' "Key or index '$key' is not in '$filter_stack_string'"
+			return
 		# If 'key' is a member of an object or index of array
 		else
 			local key_value="${current_object["$key"]}"

pkg/lib/traverse-set.sh

@@ -33,28 +33,19 @@ bash_object.traverse-set() {
 		local key="${REPLIES[$i]}"
 		filter_stack+=("$key")
 
+		local oldIFS="$IFS"
+		IFS='_'
+		local filter_stack_string="${filter_stack[*]}"
+		IFS="$oldIFS"
+
 		bash_object.trace_loop
 
 		# If 'key' is not a member of object or index of array, error
 		if [ -z "${current_object["$key"]+x}" ]; then
 			# If we are before the last element in the query, then error
 			if ((i+1 < ${#REPLIES[@]})); then
-				echo "could not traverse property does not exist"
-				return 2
-			# 	# The variable is 'new_current_object_name', but it also could
-			# 	# be the name of a new _array_
-			# 	local new_current_object_name="__bash_object_${root_object_name}_tree_${key}_${RANDOM}_${RANDOM}_${RANDOM}_${RANDOM}_${RANDOM}"
-
-			# 	if ! eval "declare -gA $new_current_object_name=()"; then
-			# 		printf '%s\n' 'Error: bash-object: eval declare failed'
-			# 		return 1
-			# 	fi
-
-			# 	current_object["$key"]=$'\x1C\x1D'"type=object;&$new_current_object_name"
-
-			# 	current_object_name="$new_current_object_name"
-			# 	# shellcheck disable=SC2178
-			# 	local -n current_object="$new_current_object_name"
+					bash_object.util.die 'ERROR_VALUE_NOT_FOUND' "Key or index '$key' is not in '$filter_stack_string'"
+					return
 			# If we are at the last element in the query
 			elif ((i+1 == ${#REPLIES[@]})); then
 				if [ "$final_value_type" = object ]; then
@@ -63,11 +54,6 @@ bash_object.traverse-set() {
 						return
 					fi
 
-					local oldIFS="$IFS"
-					IFS='_'
-					local filter_stack_string="${filter_stack[*]}"
-					IFS="$oldIFS"
-
 					bash_object.util.generate_vobject_name "$root_object_name" "$filter_stack_string"
 					local global_object_name="$REPLY"
 
@@ -101,11 +87,6 @@ bash_object.traverse-set() {
 						return
 					fi
 
-					local oldIFS="$IFS"
-					IFS='_'
-					local filter_stack_string="${filter_stack[*]}"
-					IFS="$oldIFS"
-
 					bash_object.util.generate_vobject_name "$root_object_name" "$filter_stack_string"
 					local global_array_name="$REPLY"