fix: No longer error on set-string

Error was caused by testing if the string to set is a variable. This was
changed to only be done for set-object and set-array

Author: hyperupcall

pkg/lib/traverse-set.sh

@@ -11,9 +11,10 @@ bash_object.traverse-set() {
 	local filter="$3"
 	local final_value="$4"
 
-	# TODO: test this
-	if bash_object.ensure.variable_does_exist "$final_value"; then :; else
-		return
+	# TODO: test, old versions of bash
+	if [[ ! -v 4 ]]; then
+			bash_object.util.die 'ERROR_INTERNAL_MISCELLANEOUS' "final_value is empty"
+			return
 	fi
 
 	# Start traversing at the root object
@@ -57,6 +58,11 @@ bash_object.traverse-set() {
 			# If we are at the last element in the query
 			elif ((i+1 == ${#REPLIES[@]})); then
 				if [ "$final_value_type" = object ]; then
+					# TODO: test this
+					if bash_object.ensure.variable_does_exist "$final_value"; then :; else
+						return
+					fi
+
 					local oldIFS="$IFS"
 					IFS='_'
 					local filter_stack_string="${filter_stack[*]}"
@@ -90,6 +96,11 @@ bash_object.traverse-set() {
 						globel_object["$key"]="${object_to_copy_from["$key"]}"
 					done
 				elif [ "$final_value_type" = array ]; then
+					# TODO: test this
+					if bash_object.ensure.variable_does_exist "$final_value"; then :; else
+						return
+					fi
+
 					local oldIFS="$IFS"
 					IFS='_'
 					local filter_stack_string="${filter_stack[*]}"

tests/set.bats

@@ -3,12 +3,14 @@
 load './util/init.sh'
 
 @test "Error if random variable already exists" {
+	declare -gA objj=()
+
 	bash_object.util.generate_vobject_name() {
 		REPLY="some_other_var"
 	}
 	declare -g some_other_var=
 
-	run bash_object.traverse-set object 'OBJECT' '.obj' obj
+	run bash_object.traverse-set object 'OBJECT' '.obj' objj
 
 	assert_failure
 	assert_output -p 'ERROR_INTERNAL_MISCELLANEOUS'