feat: Add --all flags to install all packages for a particular project. Closes #47

It does this by reading the 'dependencies' key in bpm.toml and installing
those one after another

Author: hyperupcall

pkg/lib/commands/do-add.sh

@@ -1,20 +1,44 @@
 # shellcheck shell=bash
 
 do-add() {
-	local with_ssh='no'
+	local with_ssh='no' # TODO: refactor flag_
+	local flag_all='no'
 
 	local -a pkgs=()
 	for arg; do
 		case "$arg" in
 		--ssh)
 			with_ssh='yes'
 			;;
+		--all)
+			flag_all='yes'
+			;;
 		*)
 			pkgs+=("$arg")
 			;;
 		esac
 	done
 
+	if [ "$flag_all" = yes ]; then
+		local bpm_toml_file="$BPM_ROOT/bpm.toml"
+
+		if (( ${#pkgs[@]} > 0 )); then
+			die "You must not supply any packages when using '--all'"
+		fi
+
+		if util.get_toml_array "$bpm_toml_file" 'dependencies'; then
+			log.info "Adding all dependencies"
+
+			for pkg in "${REPLIES[@]}"; do
+				do-add "$pkg"
+			done
+		else
+			log.warn "No dependencies specified in 'dependencies' key"
+		fi
+
+		return
+	fi
+
 	if (( ${#pkgs[@]} == 0 )); then
 		die "At least one package must be supplied"
 	fi

pkg/lib/commands/do-remove.sh

@@ -1,11 +1,45 @@
 # shellcheck shell=bash
 
 do-remove() {
-	if (( $# == 0 )); then
+	local flag_all='no'
+
+	local -a pkgs=()
+	for arg; do
+		case "$arg" in
+			--all)
+				flag_all='yes'
+				;;
+			*)
+				pkgs+=("$arg")
+				;;
+		esac
+	done
+
+	if [ "$flag_all" = yes ]; then
+		local bpm_toml_file="$BPM_ROOT/bpm.toml"
+
+		if (( ${#pkgs[@]} > 0 )); then
+			die "You must not supply any packages when using '--all'"
+		fi
+
+		if util.get_toml_array "$bpm_toml_file" 'dependencies'; then
+			log.info "Removing all dependencies"
+
+			for pkg in "${REPLIES[@]}"; do
+				do-remove "$pkg"
+			done
+		else
+			log.warn "No dependencies specified in 'dependencies' key"
+		fi
+
+		return
+	fi
+
+	if (( ${#pkgs[@]} == 0 )); then
 		die "You must supply at least one package"
 	fi
 
-	for repoSpec; do
+	for repoSpec in "${pkgs[@]}"; do
 		util.extract_data_from_input "$repoSpec"
 		local site="$REPLY2"
 		local package="$REPLY3"

pkg/lib/util/abstract-completions.sh

@@ -200,7 +200,7 @@ abstract.completions_do_action_fish() {
 	case "$action" in
 	link)
 		if [ -L "$BPM_INSTALL_COMPLETIONS/fish/${file##*/}" ]; then
-				log.error "Skipping '$fileName' since an existing symlink with the same name already exists"
+			log.error "Skipping '$fileName' since an existing symlink with the same name already exists"
 		else
 			mkdir -p "$BPM_INSTALL_COMPLETIONS/fish"
 			ln -sf "$file" "$BPM_INSTALL_COMPLETIONS/fish/${file##*/}"

pkg/lib/util/util.sh

@@ -258,10 +258,10 @@ Subcommands:
   init <shell>
     Configure shell environment for Basher
 
-  add [--ssh] [[site/]<package>[@ref]...]
+  add [--ssh] [--all] [[site/]<package>[@ref]...]
     Installs a package from GitHub (or a custom site)
 
-  remove <package...>
+  remove [--all] <package...>
     Uninstalls a package
 
   link [--no-deps] <directory...>

tests/do-add.bats

@@ -204,3 +204,22 @@ load 'util/init.sh'
 	assert_success
 	assert_line "do-plumbing-clone https://github.com/username/package.git github.com/username/package"
 }
+
+@test "--all prints warning when no dependencies are specified in bpm.toml" {
+	touch 'bpm.toml'
+
+	run do-add --all
+
+	assert_success
+	assert_line -p "No dependencies specified in 'dependencies' key"
+	refute_line -p "Installing"
+}
+
+@test "--all errors when a package is specified as argument" {
+	touch 'bpm.toml'
+
+	run do-add --all pkg
+
+	assert_failure
+	assert_line -p "You must not supply any packages when using '--all'"
+}

tests/do-remove.bats

@@ -156,3 +156,22 @@ load 'util/init.sh'
 	assert [ -d "$BPM_PACKAGES_PATH/$site/$pkg2" ]
 	assert [ -e "$BPM_INSTALL_BIN/exec2" ]
 }
+
+@test "--all prints warning when no dependencies are specified in bpm.toml" {
+	touch 'bpm.toml'
+
+	run do-remove --all
+
+	assert_success
+	assert_line -p "No dependencies specified in 'dependencies' key"
+	refute_line -p "Installing"
+}
+
+@test "--all errors when a package is specified as argument" {
+	touch 'bpm.toml'
+
+	run do-remove --all pkg
+
+	assert_failure
+	assert_line -p "You must not supply any packages when using '--all'"
+}