fix: Remove erroneous 'Skipping fileName existing symlink' errors for man pages

This arised because the man page autodetector (search_heuristics function) searched subdirectories of subdirectories,
as well as directories. So when the root path was searched, it looked in the 'man' subdirectory. Since we already looked
in 'man', there was a collision. So the code was updated to only look for man _files_ at the root of the directory

Author: hyperupcall

pkg/lib/util/abstract-mans.sh

@@ -52,7 +52,7 @@ abstract.mans_search_heuristics() {
 	local action="$1"
 	local id="$2"
 
-	for file in "$BPM_PACKAGES_PATH/$id"/{,man/}*; do
+	for file in "$BPM_PACKAGES_PATH/$id"/man/*; do
 		if [ -f "$file" ]; then
 			abstract.mans_do_action "$action" "$file"
 		elif [ -d "$file" ]; then
@@ -63,6 +63,12 @@ abstract.mans_search_heuristics() {
 			done
 		fi
 	done
+
+	for file in "$BPM_PACKAGES_PATH/$id"/*; do
+		if [ -f "$file" ]; then
+			abstract.mans_do_action "$action" "$file"
+		fi
+	done
 }
 
 # @arg $1 The man file to symlink or remove. Not all the files passed

tests/do-plumbing-link-man.bats

@@ -94,24 +94,6 @@ load 'util/init.sh'
 	assert [ "$(readlink "$BPM_INSTALL_MAN/man2/exec.2")" = "$BPM_PACKAGES_PATH/$site/$pkg/man/2man/exec.2" ]
 }
 
-@test "adds man page determined from heuristics (manN directory)" {
-	local site='github.com'
-	local pkg='username/package'
-
-	test_util.setup_pkg "$pkg"; {
-		mkdir {1,2}man
-		touch '1man/exec.1'
-		touch '2man/exec.2'
-	}; test_util.finish_pkg
-	test_util.mock_add "$pkg"
-
-	run do-plumbing-link-man "$site/$pkg"
-
-	assert_success
-	assert [ "$(readlink "$BPM_INSTALL_MAN/man1/exec.1")" = "$BPM_PACKAGES_PATH/$site/$pkg/1man/exec.1" ]
-	assert [ "$(readlink "$BPM_INSTALL_MAN/man2/exec.2")" = "$BPM_PACKAGES_PATH/$site/$pkg/2man/exec.2" ]
-}
-
 @test "adds man page determined from heuristics (root directory)" {
 	local site='github.com'
 	local pkg='username/package'