Skip to content

Commit d26c423

Browse files
committed
refactor: Rename test 'fake_*' to mock and mock to stub
1 parent 75cb2de commit d26c423

16 files changed

+270
-273
lines changed

tests/do-add.bats

Lines changed: 70 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
load 'util/init.sh'
44

55
@test "fails when no packages are specified" {
6-
test_util.mock_command do-plumbing-clone
7-
test_util.mock_command do-plumbing-add-deps
8-
test_util.mock_command do-plumbing-link-bins
9-
test_util.mock_command do-plumbing-link-completions
10-
test_util.mock_command do-plumbing-link-man
6+
test_util.stub_command do-plumbing-clone
7+
test_util.stub_command do-plumbing-add-deps
8+
test_util.stub_command do-plumbing-link-bins
9+
test_util.stub_command do-plumbing-link-completions
10+
test_util.stub_command do-plumbing-link-man
1111

1212
run do-add
1313

@@ -16,11 +16,11 @@ load 'util/init.sh'
1616
}
1717

1818
@test "fails when the remote repository is owned by a user with username 'local'" {
19-
test_util.mock_command do-plumbing-clone
20-
test_util.mock_command do-plumbing-add-deps
21-
test_util.mock_command do-plumbing-link-bins
22-
test_util.mock_command do-plumbing-link-completions
23-
test_util.mock_command do-plumbing-link-man
19+
test_util.stub_command do-plumbing-clone
20+
test_util.stub_command do-plumbing-add-deps
21+
test_util.stub_command do-plumbing-link-bins
22+
test_util.stub_command do-plumbing-link-completions
23+
test_util.stub_command do-plumbing-link-man
2424

2525
run do-add 'local/pkg'
2626

@@ -32,11 +32,11 @@ load 'util/init.sh'
3232
local site='github.com'
3333
local pkg='username/main'
3434

35-
test_util.mock_command do-plumbing-clone
36-
test_util.mock_command do-plumbing-add-deps
37-
test_util.mock_command do-plumbing-link-bins
38-
test_util.mock_command do-plumbing-link-completions
39-
test_util.mock_command do-plumbing-link-man
35+
test_util.stub_command do-plumbing-clone
36+
test_util.stub_command do-plumbing-add-deps
37+
test_util.stub_command do-plumbing-link-bins
38+
test_util.stub_command do-plumbing-link-completions
39+
test_util.stub_command do-plumbing-link-man
4040

4141
test_util.create_package "$pkg"
4242
run do-add "$BPM_ORIGIN_DIR/$site/$pkg"
@@ -46,11 +46,11 @@ load 'util/init.sh'
4646
}
4747

4848
@test "executes install steps in right order" {
49-
test_util.mock_command do-plumbing-clone
50-
test_util.mock_command do-plumbing-add-deps
51-
test_util.mock_command do-plumbing-link-bins
52-
test_util.mock_command do-plumbing-link-completions
53-
test_util.mock_command do-plumbing-link-man
49+
test_util.stub_command do-plumbing-clone
50+
test_util.stub_command do-plumbing-add-deps
51+
test_util.stub_command do-plumbing-link-bins
52+
test_util.stub_command do-plumbing-link-completions
53+
test_util.stub_command do-plumbing-link-man
5454

5555
run do-add username/package
5656

@@ -64,11 +64,11 @@ load 'util/init.sh'
6464
}
6565

6666
@test "executes install steps in right order for multiple packages" {
67-
test_util.mock_command do-plumbing-clone
68-
test_util.mock_command do-plumbing-add-deps
69-
test_util.mock_command do-plumbing-link-bins
70-
test_util.mock_command do-plumbing-link-completions
71-
test_util.mock_command do-plumbing-link-man
67+
test_util.stub_command do-plumbing-clone
68+
test_util.stub_command do-plumbing-add-deps
69+
test_util.stub_command do-plumbing-link-bins
70+
test_util.stub_command do-plumbing-link-completions
71+
test_util.stub_command do-plumbing-link-man
7272

7373
run do-add username/package username2/package2
7474

@@ -89,11 +89,11 @@ load 'util/init.sh'
8989

9090

9191
@test "uses longhand (https) site to clone from, if specified" {
92-
test_util.mock_command do-plumbing-clone
93-
test_util.mock_command do-plumbing-add-deps
94-
test_util.mock_command do-plumbing-link-bins
95-
test_util.mock_command do-plumbing-link-completions
96-
test_util.mock_command do-plumbing-link-man
92+
test_util.stub_command do-plumbing-clone
93+
test_util.stub_command do-plumbing-add-deps
94+
test_util.stub_command do-plumbing-link-bins
95+
test_util.stub_command do-plumbing-link-completions
96+
test_util.stub_command do-plumbing-link-man
9797

9898
run do-add https://gitlab.com/username/package
9999

@@ -102,11 +102,11 @@ load 'util/init.sh'
102102
}
103103

104104
@test "uses longhand (http) site to clone from, if specified" {
105-
test_util.mock_command do-plumbing-clone
106-
test_util.mock_command do-plumbing-add-deps
107-
test_util.mock_command do-plumbing-link-bins
108-
test_util.mock_command do-plumbing-link-completions
109-
test_util.mock_command do-plumbing-link-man
105+
test_util.stub_command do-plumbing-clone
106+
test_util.stub_command do-plumbing-add-deps
107+
test_util.stub_command do-plumbing-link-bins
108+
test_util.stub_command do-plumbing-link-completions
109+
test_util.stub_command do-plumbing-link-man
110110

111111
run do-add http://gitlab.com/username/package
112112

@@ -115,11 +115,11 @@ load 'util/init.sh'
115115
}
116116

117117
@test "uses shorthand site to clone from, if specified" {
118-
test_util.mock_command do-plumbing-clone
119-
test_util.mock_command do-plumbing-add-deps
120-
test_util.mock_command do-plumbing-link-bins
121-
test_util.mock_command do-plumbing-link-completions
122-
test_util.mock_command do-plumbing-link-man
118+
test_util.stub_command do-plumbing-clone
119+
test_util.stub_command do-plumbing-add-deps
120+
test_util.stub_command do-plumbing-link-bins
121+
test_util.stub_command do-plumbing-link-completions
122+
test_util.stub_command do-plumbing-link-man
123123

124124
run do-add site/username/package
125125

@@ -128,11 +128,11 @@ load 'util/init.sh'
128128
}
129129

130130
@test "uses GitHub as default site, if not specified" {
131-
test_util.mock_command do-plumbing-clone
132-
test_util.mock_command do-plumbing-add-deps
133-
test_util.mock_command do-plumbing-link-bins
134-
test_util.mock_command do-plumbing-link-completions
135-
test_util.mock_command do-plumbing-link-man
131+
test_util.stub_command do-plumbing-clone
132+
test_util.stub_command do-plumbing-add-deps
133+
test_util.stub_command do-plumbing-link-bins
134+
test_util.stub_command do-plumbing-link-completions
135+
test_util.stub_command do-plumbing-link-man
136136

137137
run do-add username/package
138138

@@ -141,11 +141,11 @@ load 'util/init.sh'
141141
}
142142

143143
@test "uses ssh protocol, when specified" {
144-
test_util.mock_command do-plumbing-clone
145-
test_util.mock_command do-plumbing-add-deps
146-
test_util.mock_command do-plumbing-link-bins
147-
test_util.mock_command do-plumbing-link-completions
148-
test_util.mock_command do-plumbing-link-man
144+
test_util.stub_command do-plumbing-clone
145+
test_util.stub_command do-plumbing-add-deps
146+
test_util.stub_command do-plumbing-link-bins
147+
test_util.stub_command do-plumbing-link-completions
148+
test_util.stub_command do-plumbing-link-man
149149

150150
run do-add --ssh username/package
151151

@@ -154,11 +154,11 @@ load 'util/init.sh'
154154
}
155155

156156
@test "uses ssh protocol, when specified (at end)" {
157-
test_util.mock_command do-plumbing-clone
158-
test_util.mock_command do-plumbing-add-deps
159-
test_util.mock_command do-plumbing-link-bins
160-
test_util.mock_command do-plumbing-link-completions
161-
test_util.mock_command do-plumbing-link-man
157+
test_util.stub_command do-plumbing-clone
158+
test_util.stub_command do-plumbing-add-deps
159+
test_util.stub_command do-plumbing-link-bins
160+
test_util.stub_command do-plumbing-link-completions
161+
test_util.stub_command do-plumbing-link-man
162162

163163
run do-add username/package --ssh
164164

@@ -167,11 +167,11 @@ load 'util/init.sh'
167167
}
168168

169169
@test "uses ssh protocol raw, when specified" {
170-
test_util.mock_command do-plumbing-clone
171-
test_util.mock_command do-plumbing-add-deps
172-
test_util.mock_command do-plumbing-link-bins
173-
test_util.mock_command do-plumbing-link-completions
174-
test_util.mock_command do-plumbing-link-man
170+
test_util.stub_command do-plumbing-clone
171+
test_util.stub_command do-plumbing-add-deps
172+
test_util.stub_command do-plumbing-link-bins
173+
test_util.stub_command do-plumbing-link-completions
174+
test_util.stub_command do-plumbing-link-man
175175

176176
run do-add git@github.com:username/package
177177

@@ -180,11 +180,11 @@ load 'util/init.sh'
180180
}
181181

182182
@test "uses custom version, when specified" {
183-
test_util.mock_command do-plumbing-clone
184-
test_util.mock_command do-plumbing-add-deps
185-
test_util.mock_command do-plumbing-link-bins
186-
test_util.mock_command do-plumbing-link-completions
187-
test_util.mock_command do-plumbing-link-man
183+
test_util.stub_command do-plumbing-clone
184+
test_util.stub_command do-plumbing-add-deps
185+
test_util.stub_command do-plumbing-link-bins
186+
test_util.stub_command do-plumbing-link-completions
187+
test_util.stub_command do-plumbing-link-man
188188

189189
run do-add username/package@v1.2.3
190190

@@ -193,17 +193,14 @@ load 'util/init.sh'
193193
}
194194

195195
@test "does not use custom version, when not specified" {
196-
test_util.mock_command do-plumbing-clone
197-
test_util.mock_command do-plumbing-add-deps
198-
test_util.mock_command do-plumbing-link-bins
199-
test_util.mock_command do-plumbing-link-completions
200-
test_util.mock_command do-plumbing-link-man
196+
test_util.stub_command do-plumbing-clone
197+
test_util.stub_command do-plumbing-add-deps
198+
test_util.stub_command do-plumbing-link-bins
199+
test_util.stub_command do-plumbing-link-completions
200+
test_util.stub_command do-plumbing-link-man
201201

202202
run do-add username/package@
203203

204204
assert_success
205205
assert_line "do-plumbing-clone https://github.com/username/package.git github.com/username/package"
206206
}
207-
208-
209-

0 commit comments

Comments
 (0)