fix: add --all does not fail if packages are already installed

Author: hyperupcall

pkg/lib/commands/do-add.sh

@@ -84,7 +84,17 @@ do-actual-add() {
 		die "Cannot install packages owned by username 'local' because that conflicts with linked packages"
 	fi
 
-	log.info "Adding '$repoSpec'"
+	if [ -e "$BPM_PACKAGES_PATH/$site/$package" ]; then
+		if [ "$BPM_IS_LOCAL" = yes ]; then
+			log.info "Skipping '$site/$package' as it's already present"
+			return
+		else
+			die "Package '$site/$package' is already present"
+		fi
+	else
+		log.info "Adding '$repoSpec'"
+	fi
+
 	do-plumbing-clone "$uri" "$site/$package" "$ref" "$flag_branch"
 	do-plumbing-add-deps "$site/$package"
 	do-plumbing-link-bins "$site/$package"

tests/do-add.bats

@@ -310,3 +310,26 @@ load 'util/init.sh'
 	assert_failure
 	assert_line -p "Cannot pass '--all' without a 'bpm.toml' file"
 }
+
+@test "--all works if some are already installed" {
+	local site='github.com'
+	local pkg1='user/project'
+	local pkg2='user/project2'
+
+	test_util.create_package "$pkg1"
+	test_util.create_package "$pkg2"
+
+	echo "dependencies = [ 'file://$BPM_ORIGIN_DIR/$pkg1' ]" > 'bpm.toml'
+	BPM_IS_LOCAL='yes' run do-add --all
+
+	assert_success
+
+	echo "dependencies = [ 'file://$BPM_ORIGIN_DIR/$pkg1', 'file://$BPM_ORIGIN_DIR/$pkg2' ]" > 'bpm.toml'
+	BPM_IS_LOCAL='yes' run do-add --all
+
+	assert_success
+	assert [ -d "./bpm_packages/packages/$site/$pkg1" ]
+	assert [ -d "./bpm_packages/packages/$site/$pkg1/.git" ]
+	assert [ -d "./bpm_packages/packages/$site/$pkg2" ]
+	assert [ -d "./bpm_packages/packages/$site/$pkg2/.git" ]
+}