fix: Improve error handling and output of Git command errors

Author: hyperupcall

pkg/lib/commands/do-list.sh

@@ -120,8 +120,9 @@ echo_package_info() {
 		if git -C "$pkg_path" config remote.origin.url &>/dev/null; then
 			if [ "$flag_fetch" = yes ]; then
 				local git_output=
-				if ! git_output="$(git -C "$pkg_path" fetch)"; then
-					printf "%s\n" "$git_output"
+				if ! git_output="$(git -C "$pkg_path" fetch 2>&1)"; then
+					printf "  --> %s\n" "Git output:"
+					printf "    --> %s\n" "${git_output%.}"
 				fi
 			fi
 

pkg/lib/commands/do-plumbing-clone.sh

@@ -30,7 +30,8 @@ do-plumbing-clone() {
 	local git_output=
 	if ! git_output="$(git clone "${git_args[@]}" 2>&1)"; then
 		log.error "Could not clone repository"
-		printf "%s\n" "$git_output"
+		printf "  --> %s\n" "Git output:"
+		printf "    --> %s\n" "${git_output%.}"
 		exit 1
 	fi
 

pkg/lib/commands/do-prune.sh

@@ -8,7 +8,9 @@ do-prune() {
 
 	for file in "$BPM_INSTALL_BIN"/* "$BPM_INSTALL_MAN"/*/* "$BPM_INSTALL_COMPLETIONS"/{bash,zsh/{compsys,compctl},fish}/*; do
 		local real_file=
-		real_file="$(readlink "$file")"
+		if ! real_file="$(readlink "$file")"; then
+			die "Readlink '$file' unexpectedly failed"
+		fi
 
 		if [[ "${real_file:0:1}" == / && -e "$real_file" ]]; then
 			# The only valid symlinks 'bpm' creates are absolute paths
@@ -17,6 +19,8 @@ do-prune() {
 		fi
 
 		printf '  -> %s\n' "Unsymlinking broken symlink '$file'"
-		unlink "$file"
+		if ! unlink "$file"; then
+			die "Unlink '$file' unexpectedly failed"
+		fi
 	done
 }

pkg/lib/commands/do-remove.sh

@@ -101,7 +101,9 @@ do_actual_removal() {
 
 	if [ "${id%%/*}" = 'local' ]; then
 		printf '  -> %s\n' "Unsymlinking directory"
-		unlink "$BPM_PACKAGES_PATH/$id"
+		if ! unlink "$BPM_PACKAGES_PATH/$id"; then
+			die "Unlink '$BPM_PACKAGES_PATH/$id' unexpectedly failed"
+		fi
 	else
 		printf '  -> %s\n' "Removing Git repository"
 		rm -rf "${BPM_PACKAGES_PATH:?}/$id"

pkg/lib/commands/do-upgrade.sh

@@ -111,7 +111,8 @@ do_actual_upgrade() {
 	local git_output=
 	if ! git_output="$(git -C "$BPM_PACKAGES_PATH/$id" pull 2>&1)"; then
 		log.error "Could not update Git repository"
-		printf "%s\n" "$git_output"
+		printf "  --> %s\n" "Git output:"
+		printf "    --> %s\n" "${git_output%.}"
 		exit 1
 	fi