-
Notifications
You must be signed in to change notification settings - Fork 14
Conformal Prediction Wrappers #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soulios-basf
wants to merge
21
commits into
main
Choose a base branch
from
conformal_pred
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JochenSiegWork
requested changes
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first part of my review. I mainly looked at conformal.py
and only shortly on the test.
…ests, random_states, hide priv functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR introduces several new files to support conformal prediction in molecular machine learning pipelines, as well as comprehensive unit tests for pipeline and conformal prediction functionality.
conformal.py: Implements UnifiedConformalCV(single-model) and CrossConformalCV(aggregate CP) wrappers for easy conformal prediction (classification/regression) on top of scikit-learn models.
test_conformal.py: Unit tests for the conformal wrappers, covering both regression and classification.
test_pipeline.py: Unit tests for the main pipeline, including integration with conformal prediction.
advanced_04_conformal_prediction.ipynb: Example notebook showing conformal prediction on molecular data, with benchmarking and visualization.
How to test:
Run pytest on the new test files to verify correctness.
Open and run all cells in the notebook to see conformal prediction in action.