Skip to content

Conversation

@mur-me
Copy link

@mur-me mur-me commented Nov 11, 2025

Today I found an issue with additional args in reth entrypoint, one of my args want propagate to the reth.

I've checked the code and found the root cause, ADDITIONAL_ARGS="--websocket-url=$RETH_FB_WEBSOCKET_URL" is completely rewriting the ADDITIONAL_ARGS value.

Funny, that pruning agrs don't have this issue

What was done:

  • add append instead of rewritting
  • add explicit echo

…ewritting, add explicit echo for additional arguments
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 11, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@mur-me mur-me changed the title fix(reth_entrypoint): add flashblocks to additional args instead of r… fix(reth_entrypoint): add flashblocks to additional args instead of rewritting Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants